Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner donnation december #1444

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Conversation

LuizFNJ
Copy link
Collaborator

@LuizFNJ LuizFNJ commented Nov 6, 2024

Description

Donation Banner December Campaign
home:
Screenshot from 2024-11-06 15-34-54

on any other page there is a header:
Screenshot from 2024-11-06 15-35-15

Fixes #1386

Questions

  • The hide button is necessary?
  • When the user is not logged in on the homepage, there will be 3 donation buttons. I would suggest hiding the donation button in the header when the banner is being displayed.

Note

I haven't done the responsiveness for smaller screens yet. I'm facing difficulties in the development environment because the layout is breaking at 768px, regardless of the changes I make.

@LuizFNJ LuizFNJ requested a review from thesocialdev as a code owner November 6, 2024 16:31
@LuizFNJ LuizFNJ force-pushed the Create-banner-donnation-december branch from c1ac563 to 9c38166 Compare November 6, 2024 16:47
@thesocialdev thesocialdev force-pushed the stage branch 4 times, most recently from 359f30b to c3ea80c Compare November 7, 2024 11:48
@thesocialdev thesocialdev force-pushed the stage branch 2 times, most recently from 05f8912 to 864c35e Compare November 7, 2024 18:27
@LuizFNJ LuizFNJ force-pushed the Create-banner-donnation-december branch 4 times, most recently from 4ffa99d to 73df83b Compare November 8, 2024 12:18
@LuizFNJ LuizFNJ force-pushed the Create-banner-donnation-december branch 2 times, most recently from 422902a to 7a0689a Compare November 8, 2024 18:05
@LuizFNJ LuizFNJ requested a review from thesocialdev November 8, 2024 18:07
@LuizFNJ LuizFNJ force-pushed the Create-banner-donnation-december branch from 3882a81 to b14254c Compare November 13, 2024 17:12
Dockerfile Outdated Show resolved Hide resolved
@LuizFNJ LuizFNJ force-pushed the Create-banner-donnation-december branch from ff4776b to bd3724e Compare November 18, 2024 16:52
@LuizFNJ LuizFNJ requested a review from thesocialdev November 18, 2024 17:23
@LuizFNJ LuizFNJ requested a review from thesocialdev November 18, 2024 19:01
@thesocialdev thesocialdev merged commit 46b49a2 into stage Nov 18, 2024
7 checks passed
@thesocialdev thesocialdev mentioned this pull request Dec 15, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: December Donation Banner
2 participants