Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly manage loading state for fetching results #1471

Merged
merged 3 commits into from
Dec 15, 2024

Conversation

caneppelevitor
Copy link
Collaborator

@caneppelevitor caneppelevitor commented Nov 25, 2024

Description

Correctly manage loading state for fetching results

Fixes #1485

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

Search any text on overlay input and check if the results are displayed

Developer Checklist

General

  • Code is appropriately commented, particularly in hard-to-understand areas
  • Repository documentation has been updated (Readme.md) with additional steps required for a local environment setup.
  • No console.log or related logging is added.
  • No code is repeated/duplicated in violation of DRY. The exception to this is for new (MVP/Prototype) functionality where the abstraction layer may not be clear (comments should be added to explain the violation of DRY in these scenarios).
  • Documented with TSDoc all library and controller new functions

Frontend Changes

  • No new styling is added through CSS files (Unless it's a bugfix/hotfix)
  • All types are added correctly

Backend Changes

  • All endpoints are appropriately secured with Middleware authentication
  • All new endpoints have a interface schema defined

Tests

  • All existing unit and end to end tests pass across all services
  • Unit and end to end tests have been added to ensure backend APIs behave as expected

Merge Request Review Checklist

  • An issue is linked to this PR and these changes meet the requirements outlined in the linked issue(s)
  • High risk and core workflows have been tested and verified in a local environment.
  • Enhancements or opportunities to improve performance, stability, security or code readability have been noted and documented in JIRA issues if not being addressed.
  • Any dependent changes have been merged and published in downstream modules
  • Changes to multiple services can be deployed in parallel and independently. If not, changes should be broken out into separate merge requests and deployed in order.

@thesocialdev
Copy link
Collaborator

@caneppelevitor please create an issue and move to the QA board for the QA process to complete.

@caneppelevitor
Copy link
Collaborator Author

@caneppelevitor please create an issue and move to the QA board for the QA process to complete.

#1485

Copy link

sonarqubecloud bot commented Dec 3, 2024

@thesocialdev thesocialdev merged commit 1bc46df into stage Dec 15, 2024
7 checks passed
@thesocialdev thesocialdev deleted the fix-load-search-overlay branch December 15, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA
Development

Successfully merging this pull request may close these issues.

Eternal Loading on Overlay Search Results
2 participants