Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling image attachments and animated images in current conversation #162

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

winstona
Copy link

Image attachments and animated images would fail to show any message indication when conversation is open despite successfully showing when the conversation is refreshed/reopened.

This adds extra filters for these message types

@cgmcintyr
Copy link

Using your fork, images seem to only show the preview rather than the actual image.

I couldn't get images to show using the original master branch, so at least it's a step in the right direction, thanks :)

@p1ho
Copy link

p1ho commented May 28, 2019

The problem this PR addresses is still an ongoing issue. I feel like getting images to show is more important, and the preview problem can be solved in a separate PR as there was a separate issue opened for it. #157

This PR does not address other file types though (video, audio, file still show up as blank message), even though theoretically the handling principle should be the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants