Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#127] Forced declare strict type. #129

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented Apr 24, 2024

Checklist before requesting a review

closes #127

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

@tannguyen04 tannguyen04 marked this pull request as ready for review April 24, 2024 05:09
@AlexSkrypnyk AlexSkrypnyk merged commit b0d64d1 into 1.x Apr 24, 2024
18 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/force-declare-strict-type branch April 24, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated Rector rules to force declare(strict_types=1);
2 participants