-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#126] Added bats test for ahoy operations #140
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.x #140 +/- ##
===========================================
+ Coverage 54.52% 76.14% +21.62%
===========================================
Files 8 8
Lines 431 436 +5
===========================================
+ Hits 235 332 +97
+ Misses 196 104 -92 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be tests for ahoy
(ahoy build
, ahoy test
etc.)
There also should be tests for breaking code linting and tests. See for example https://github.com/drevops/scaffold/blob/ac98082b947c81196158a69983132559dcbcbf57/.scaffold/tests/bats/_helper.workflow.bash#L357
closes #126
Checklist before requesting a review
[#123] Verb in past tense with dot at the end.
Changed
section about WHY something was done if this was not a normal implementationChanged
Screenshots