Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#126] Added bats test for ahoy operations #140

Merged
merged 26 commits into from
May 8, 2024

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented May 3, 2024

closes #126

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

Copy link

github-actions bot commented May 3, 2024

@github-actions github-actions bot temporarily deployed to pull request May 3, 2024 10:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 3, 2024 14:35 Inactive
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.14%. Comparing base (d0709ff) to head (fea9449).

Additional details and impacted files
@@             Coverage Diff             @@
##              1.x     #140       +/-   ##
===========================================
+ Coverage   54.52%   76.14%   +21.62%     
===========================================
  Files           8        8               
  Lines         431      436        +5     
===========================================
+ Hits          235      332       +97     
+ Misses        196      104       -92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tannguyen04 tannguyen04 marked this pull request as ready for review May 3, 2024 14:37
@github-actions github-actions bot temporarily deployed to pull request May 3, 2024 14:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 3, 2024 22:12 Inactive
@AlexSkrypnyk AlexSkrypnyk changed the title [#126] Add bats test for ahoy operations [#126] Added bats test for ahoy operations May 3, 2024
Copy link
Owner

@AlexSkrypnyk AlexSkrypnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be tests for ahoy (ahoy build, ahoy test etc.)

There also should be tests for breaking code linting and tests. See for example https://github.com/drevops/scaffold/blob/ac98082b947c81196158a69983132559dcbcbf57/.scaffold/tests/bats/_helper.workflow.bash#L357

@github-actions github-actions bot temporarily deployed to pull request May 5, 2024 10:50 Inactive
@tannguyen04 tannguyen04 marked this pull request as draft May 7, 2024 02:17
@github-actions github-actions bot temporarily deployed to pull request May 7, 2024 02:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 7, 2024 07:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 7, 2024 07:32 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 7, 2024 07:54 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 7, 2024 08:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 7, 2024 08:40 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 7, 2024 08:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 7, 2024 08:54 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 7, 2024 08:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 7, 2024 09:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 7, 2024 09:46 Inactive
@tannguyen04 tannguyen04 marked this pull request as ready for review May 7, 2024 12:40
.scaffold/tests/bats/_assert_init.bash Show resolved Hide resolved
.scaffold/tests/bats/ahoy.bats Outdated Show resolved Hide resolved
.scaffold/tests/bats/ahoy.bats Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request May 8, 2024 00:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 8, 2024 00:05 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 8, 2024 00:28 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 8, 2024 00:34 Inactive
@AlexSkrypnyk AlexSkrypnyk merged commit 0f3ae7b into 1.x May 8, 2024
17 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/add-bats-test-ahoy-operation branch May 8, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BATs tests for ahoy operations
2 participants