Skip to content

Commit

Permalink
Replaced upterm with tmate.
Browse files Browse the repository at this point in the history
  • Loading branch information
AlexSkrypnyk committed Sep 6, 2024
1 parent 8ea1d86 commit 4a8ccc6
Show file tree
Hide file tree
Showing 6 changed files with 32 additions and 36 deletions.
11 changes: 5 additions & 6 deletions .github/workflows/test-nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ on:
- 'feature/**'
workflow_dispatch:
inputs:
enable_upterm:
description: 'Set "true" to enable upterm session.'
enable_terminal:
description: 'Set "true" to enable terminal session.'
required: true

jobs:
Expand Down Expand Up @@ -42,8 +42,7 @@ jobs:
run: npm run test
continue-on-error: ${{ vars.CI_TEST_IGNORE_FAILURE == '1' }}

- name: Setup upterm session
- name: Setup tmate session
if: ${{ !cancelled() && github.event.inputs.enable_upterm == 'true' }}
uses: lhotari/action-upterm@v1
with:
wait-timeout-minutes: 5
uses: mxschmitt/action-tmate@v3
timeout-minutes: 5
24 changes: 11 additions & 13 deletions .github/workflows/test-php.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ on:
- 'feature/**'
workflow_dispatch:
inputs:
enable_upterm:
description: 'Set "true" to enable upterm session.'
enable_terminal:
description: 'Set "true" to enable terminal session.'
required: true

jobs:
Expand Down Expand Up @@ -73,11 +73,10 @@ jobs:
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

- name: Setup upterm session
if: ${{ !cancelled() && github.event.inputs.enable_upterm == 'true' }}
uses: lhotari/action-upterm@v1
with:
wait-timeout-minutes: 5
- name: Setup tmate session
if: ${{ !cancelled() && github.event.inputs.enable_terminal == 'true' }}
uses: mxschmitt/action-tmate@v3
timeout-minutes: 5

# yamllint disable-line #;< PHP_PHAR
build-php:
Expand Down Expand Up @@ -106,9 +105,8 @@ jobs:
- name: Test PHAR
run: ./.build/php-command.phar || exit 1

- name: Setup upterm session
if: ${{ !cancelled() && github.event.inputs.enable_upterm == 'true' }}
uses: lhotari/action-upterm@v1
with:
wait-timeout-minutes: 5
# yamllint disable-line #;> PHP_PHAR
- name: Setup tmate session
if: ${{ !cancelled() && github.event.inputs.enable_terminal == 'true' }}
uses: mxschmitt/action-tmate@v3
timeout-minutes: 5
# yamllint disable-line #;> PHP_PHAR

Check warning on line 112 in .github/workflows/test-php.yml

View workflow job for this annotation

GitHub Actions / test-actions

112:3 [comments-indentation] comment not indented like content
13 changes: 6 additions & 7 deletions .github/workflows/test-scaffold.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ on:
- 'feature/**'
workflow_dispatch:
inputs:
enable_upterm:
description: 'Set "true" to enable upterm session.'
enable_terminal:
description: 'Set "true" to enable terminal session.'
required: true

jobs:
Expand Down Expand Up @@ -67,8 +67,7 @@ jobs:
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

- name: Setup upterm session
if: ${{ !cancelled() && github.event.inputs.enable_upterm == 'true' }}
uses: lhotari/action-upterm@v1
with:
wait-timeout-minutes: 5
- name: Setup tmate session
if: ${{ !cancelled() && github.event.inputs.enable_terminal == 'true' }}
uses: mxschmitt/action-tmate@v3
timeout-minutes: 5
13 changes: 6 additions & 7 deletions .github/workflows/test-shell.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ on:
- 'feature/**'
workflow_dispatch:
inputs:
enable_upterm:
description: 'Set "true" to enable upterm session.'
enable_terminal:
description: 'Set "true" to enable terminal session.'
required: true

env:
Expand Down Expand Up @@ -89,8 +89,7 @@ jobs:
shell: bash
continue-on-error: ${{ vars.CI_TEST_IGNORE_FAILURE == '1' }}

- name: Setup upterm session
if: ${{ !cancelled() && github.event.inputs.enable_upterm == 'true' }}
uses: lhotari/action-upterm@v1
with:
wait-timeout-minutes: 5
- name: Setup tmate session
if: ${{ !cancelled() && github.event.inputs.enable_terminal == 'true' }}
uses: mxschmitt/action-tmate@v3
timeout-minutes: 5
2 changes: 1 addition & 1 deletion docs/content/ci/README.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ This project provides several GitHub Actions workflows to help you get started.
### SSHing into a GitHub Actions runner

If you need to SSH into a GitHub Actions runner to debug your workflows, you can
start an action manually using [lhotari/action-upterm](https://github.com/lhotari/action-upterm)
start an action manually using [mxschmitt/action-tmate](https://github.com/mxschmitt/action-tmate)
added to PHP, Node.js, and Shell workflows.

This will post the SSH details into the Actions logs looking like:
Expand Down
5 changes: 3 additions & 2 deletions docs/cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@
"daemonized",
"lhotari",
"mksh",
"mxschmitt",
"ruleset",
"softprops",
"toshimaru",
"upterm"
"tmate",
"toshimaru"
],
"overrides": [
{
Expand Down

0 comments on commit 4a8ccc6

Please sign in to comment.