-
-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hyprland/workspaces: Add enable-bar-scroll
option
#3088
base: master
Are you sure you want to change the base?
Conversation
99ceaae
to
fed413b
Compare
But why would you use both at the same time? 😄 |
Hey guys, can we please have this merged, I tested it and I need the functionality. I want to run the upstream version and not my locally built version, so that I get all updates. |
I'd like to test this out but there are way too many conflicts since the workspaces.cpp file was split up into two files. Can you fix the conflicts? |
I wish I'd found this before writing #3401. There's a small problem with this, in that events will get handled twice. For example, scrolling on volume modules will both change the volume and workspace. This is probably not ideal. |
I rebased the changes (once more) and adapted them to the new way of loading options: |
d623a89
to
a4d31ab
Compare
@Alexays could you look at this please? |
6a40179
to
01dcf62
Compare
Also interested in seeing this PR merged. |
This PR adds the option to capture scroll events for hyprland workspaces on the whole bar like it works with sway.
When using this, I had a bug that if I enable bar scroll on both hyprland and sway and put
sway/workspaces
afterhyprland/workspaces
inmodules-left
the bar scroll would no longer work on sway. When puttingsway/workspaces
first, it works on hyprland and sway. I don't know enough to track this down though.