Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicated nodeRef property #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iarroyo
Copy link

@iarroyo iarroyo commented Jul 20, 2017

No description provided.

@esplinr
Copy link

esplinr commented Jul 27, 2017

@iarroyo Can you provide some background on why you propose this change?

@iarroyo
Copy link
Author

iarroyo commented Jul 28, 2017

Hi @esplinr, sure.
Because this property is twice, and there is no point to have the same property two times.
Also some java JSON libraries like org.json doesn't manage the duplicate keys in json objects and throw an exception.

https://github.com/iarroyo/share/blob/b777916fd227f76e26fb8456651ba761671cd044/share-services/src/main/resources/alfresco/templates/webscripts/org/alfresco/slingshot/node-browser/node-browser.get.json.ftl#L47

@esplinr
Copy link

esplinr commented Aug 3, 2017

Thank you for the clarification, but I don't see the duplicate. Can you provide the line numbers?

@esplinr
Copy link

esplinr commented Aug 4, 2017

Thank you. It's all clear now.

Can you create an ALF issue linking to this pull request? It doesn't need to have any details, but I need you to check the box to accept the Alfresco Contribution Agreement. You will be the first person to go through our new process! Let me know if you have any feedback on it.

Thank you again for reporting this issue.

@iarroyo
Copy link
Author

iarroyo commented Aug 4, 2017

@esplinr the jira issue was created https://issues.alfresco.com/jira/browse/ALF-21931

@esplinr
Copy link

esplinr commented Aug 10, 2017

Thank you Ivan. We will get this scheduled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants