Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fields in Decapodes Language closes #131 #132

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Conversation

jpfairbanks
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 87.50% and no project coverage change.

Comparison is base (d2b2a79) 88.40% compared to head (a19e268) 88.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files           9        9           
  Lines        1009     1009           
=======================================
  Hits          892      892           
  Misses        117      117           
Files Changed Coverage Δ
src/Decapodes.jl 100.00% <ø> (ø)
src/language.jl 89.79% <87.50%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpfairbanks
Copy link
Member Author

@lukem12345, this is ready for a review. Shouldn't take long. The codecov error is spurious. We apparently aren't testing the Decapodes constructor (because everything is using SummationDecapode now).

Copy link
Member

@lukem12345 lukem12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, saw the code cov last night. Not an issue here. (Actually an indicator that that code should be axed.)

Tests passing. But wondering whether we ought to check such produced artifacts even though won’t affect code coverage.

@lukem12345 lukem12345 merged commit 335818f into main Jul 27, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants