SIM: Fix detectorList parsing

set_difference only accepts sorted lists, when testing I think I only ever tested with ITS/IT3 which is the first detector and thus it worked always fine... Signed-off-by: Felix Schlepper <[email protected]>
AliceO2Group · May 29, 2024 · 5b5abc2 · 5b5abc2
1 parent 68e0e4f
commit 5b5abc2
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/Common/SimConfig/src/SimConfig.cxx b/Common/SimConfig/src/SimConfig.cxx
@@ -20,7 +20,6 @@
 #include <cmath>
 #include <chrono>
 #include <regex>
-#include <algorithm>
 
 using namespace o2::conf;
 namespace bpo = boost::program_options;
@@ -197,7 +196,11 @@ bool SimConfig::determineActiveModulesList(const std::string& version, std::vect
   // check if specified modules are in list
   if (inputargs.size() != 1 || inputargs[0] != "all") {
     std::vector<std::string> diff;
-    std::set_difference(inputargs.begin(), inputargs.end(), modules.begin(), modules.end(), std::back_inserter(diff));
+    for (const auto& in : inputargs) {
+      if (std::find(modules.begin(), modules.end(), in) == std::end(modules)) {
+        diff.emplace_back(in);
+      }
+    }
     if (!diff.empty()) {
       LOGP(error, "Modules specified that are not present in detector list {}", version);
       for (int j{0}; const auto& m : diff) {
@@ -423,7 +426,11 @@ bool SimConfig::filterSkippedElements(std::vector<std::string>& elements, std::v
         LOGP(error, " + {: <2}. {}", j++, m);
       }
       std::vector<std::string> diff;
-      std::set_difference(skipped.begin(), skipped.end(), elements.begin(), elements.end(), std::back_inserter(diff));
+      for (const auto& skip : skipped) {
+        if (std::find(elements.begin(), elements.end(), skip) == std::end(elements)) {
+          diff.emplace_back(skip);
+        }
+      }
       LOGP(error, "Specified skipped modules not present in built modules:");
       for (int j{0}; const auto& m : diff) {
         LOGP(error, " - {: <2}. {}", j++, m);