Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for header stacks to RootTreeReader #1345

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Adding support for header stacks to RootTreeReader #1345

merged 1 commit into from
Sep 20, 2018

Conversation

matthiasrichter
Copy link
Collaborator

The process call is now supporting a variadic list of headers which will
be put on the stack.

@matthiasrichter
Adding support for header stacks to RootTreeReader
77af52c 
The process call is now supporting a variadic list of headers which will
be put on the stack.
@matthiasrichter
Copy link
Collaborator Author

@dberzano, I see a completely new error message on the macos CI

error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]

Has there been a change in the compiler flags?

@davidrohr, can the register keyword be avoided, or do we hit a limitation here because we are using the same code in two projects?

In file included from /build/ci_checks/o2_checker_macos_o2_ci_0/sw/osx_x86-64/AliTPCCommon/alitpccommon-v1.4.1-1/sources/TPCCAGPUTracking/SliceTracker/AliHLTTPCCATrackParam.cxx:21:
In file included from /build/ci_checks/o2_checker_macos_o2_ci_0/sw/osx_x86-64/AliTPCCommon/alitpccommon-v1.4.1-1/sources/TPCCAGPUTracking/SliceTracker/AliHLTTPCCATrackParam.h:15:
/build/ci_checks/o2_checker_macos_o2_ci_0/sw/osx_x86-64/AliTPCCommon/alitpccommon-v1.4.1-1/sources/TPCCAGPUTracking/SliceTracker/AliHLTTPCCAMath.h:48:36: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
    GPUd()  static int AtomicExch( register GPUglobalref() int *addr, int val );
                                   ^~~~~~~~~
/build/ci_checks/o2_checker_macos_o2_ci_0/sw/osx_x86-64/AliTPCCommon/alitpccommon-v1.4.1-1/sources/TPCCAGPUTracking/SliceTracker/AliHLTTPCCAMath.h:49:35: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
    GPUd()  static int AtomicAdd (register GPUglobalref() int *addr, int val );
                                  ^~~~~~~~~
/build/ci_checks/o2_checker_macos_o2_ci_0/sw/osx_x86-64/AliTPCCommon/alitpccommon-v1.4.1-1/sources/TPCCAGPUTracking/SliceTracker/AliHLTTPCCAMath.h:50:35: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
    GPUd()  static int AtomicMax (register GPUglobalref() int *addr, int val );
                                  ^~~~~~~~~
/build/ci_checks/o2_checker_macos_o2_ci_0/sw/osx_x86-64/AliTPCCommon/alitpccommon-v1.4.1-1/sources/TPCCAGPUTracking/SliceTracker/AliHLTTPCCAMath.h:51:35: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
    GPUd()  static int AtomicMin (register GPUglobalref() int *addr, int val );
                                  ^~~~~~~~~
/build/ci_checks/o2_checker_macos_o2_ci_0/sw/osx_x86-64/AliTPCCommon/alitpccommon-v1.4.1-1/sources/TPCCAGPUTracking/SliceTracker/AliHLTTPCCAMath.h:52:41: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
    GPUd()  static int AtomicExchShared(register GPUsharedref() int *addr, int val );
                                        ^~~~~~~~~
/build/ci_checks/o2_checker_macos_o2_ci_0/sw/osx_x86-64/AliTPCCommon/alitpccommon-v1.4.1-1/sources/TPCCAGPUTracking/SliceTracker/AliHLTTPCCAMath.h:53:41: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
    GPUd()  static int AtomicAddShared (register GPUsharedref() int *addr, int val );
                                        ^~~~~~~~~
/build/ci_checks/o2_checker_macos_o2_ci_0/sw/osx_x86-64/AliTPCCommon/alitpccommon-v1.4.1-1/sources/TPCCAGPUTracking/SliceTracker/AliHLTTPCCAMath.h:54:41: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
    GPUd()  static int AtomicMaxShared (register GPUsharedref() int *addr, int val );
                                        ^~~~~~~~~
/build/ci_checks/o2_checker_macos_o2_ci_0/sw/osx_x86-64/AliTPCCommon/alitpccommon-v1.4.1-1/sources/TPCCAGPUTracking/SliceTracker/AliHLTTPCCAMath.h:55:41: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
    GPUd()  static int AtomicMinShared (register GPUsharedref() int *addr, int val );
                                        ^~~~~~~~~
/build/ci_checks/o2_checker_macos_o2_ci_0/sw/osx_x86-64/AliTPCCommon/alitpccommon-v1.4.1-1/sources/TPCCAGPUTracking/SliceTracker/AliHLTTPCCAMath.h:196:48: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
GPUd()  inline int AliHLTTPCCAMath::AtomicExch(register GPUglobalref() int *addr, int val )
                                               ^~~~~~~~~
/build/ci_checks/o2_checker_macos_o2_ci_0/sw/osx_x86-64/AliTPCCommon/alitpccommon-v1.4.1-1/sources/TPCCAGPUTracking/SliceTracker/AliHLTTPCCAMath.h:209:48: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
GPUd()  inline int AliHLTTPCCAMath::AtomicAdd (register GPUglobalref() int *addr, int val )
                                               ^~~~~~~~~
/build/ci_checks/o2_checker_macos_o2_ci_0/sw/osx_x86-64/AliTPCCommon/alitpccommon-v1.4.1-1/sources/TPCCAGPUTracking/SliceTracker/AliHLTTPCCAMath.h:222:48: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
GPUd()  inline int AliHLTTPCCAMath::AtomicMax (register GPUglobalref() int *addr, int val )
                                               ^~~~~~~~~
/build/ci_checks/o2_checker_macos_o2_ci_0/sw/osx_x86-64/AliTPCCommon/alitpccommon-v1.4.1-1/sources/TPCCAGPUTracking/SliceTracker/AliHLTTPCCAMath.h:235:48: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
GPUd()  inline int AliHLTTPCCAMath::AtomicMin (register GPUglobalref() int *addr, int val )
                                               ^~~~~~~~~

@matthiasrichter
Copy link
Collaborator Author

CI failures unrelated, merging

@matthiasrichter matthiasrichter merged commit 9859df4 into AliceO2Group:dev Sep 20, 2018
@dberzano
Copy link
Contributor

@matthiasrichter nope, there's a separate PR for migrating to C++17, here it is: alisw/alidist#1293, and it hasn't been merged yet.

mikesas pushed a commit to mikesas/AliceO2 that referenced this pull request Dec 13, 2022
@nburmaso
Fix typos in UPC candidate producer and analyzer (AliceO2Group#1345)
c012e9e 
* Fix missing skimMCInfo() in MC processors

* Fix missing ampersand in getTrackBC() arguments, fix file naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthiasrichter @dberzano