-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLO: QC: Add 3d plot and widen eta cuts #13692
base: dev
Are you sure you want to change the base?
Conversation
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
pinging @mfaggin as a small reminder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot @f3sch , all looks ok to me. Just a couple of comments (not stopper at all):
- you remove lines 1178-1197. This was just a consistency check between numerator and denominator. If you found it unnecessary in your local tests then I think it's ok to remove it, otherwise keeping it it's not dangerous (in case of unexpected issues, it just drops a meaningful error)
- just an obvious reminder: since you change some cuts as we discussed (e.g. etaITS<0.9 --> etaITS<1.4), and you introduce some objects with higher dimentions (TH3) you have to remember to change the postprocessing accordingly to be able to produce plots with different eta (phi) ranges.
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
Error while checking build/O2/fullCI for 183eff0 at 2025-01-04 05:50:
Full log here. |
Allows to set the number of pt bin+range, eta cuts and sets 'reasonable' defaults in the params.
The efficiency needs to be calculated in a post-process step since TEfficiency is not projectable into smaller dim.