Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in CTPRunScalers::getRate #13814

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

shahor02
Copy link
Collaborator

No description provided.

Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

Comment on lines +704 to +705
auto s0 = sprev.scalersInps[classindex]; // type CTPScalerO2*
auto s1 = snext.scalersInps[classindex];
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lietava the real bug was here (the address of the counter was taken instead of its value) the rest is cosmetics.

@chiarazampolli
Copy link
Collaborator

Thanks @shahor02

@chiarazampolli
Copy link
Collaborator

Error unrelated:

## sw/BUILD/O2-latest/log
370/550 Test #394: Detectors/MUON/MID/Simulation/test/testSimulation.cxx ................................Subprocess aborted***Exception:   1.18 sec
99% tests passed, 1 tests failed out of 550
100% tests passed, 0 tests failed out of 32

I propose to merge.

@shahor02 shahor02 merged commit 789968c into AliceO2Group:dev Dec 18, 2024
13 of 14 checks passed
@lietava
Copy link
Contributor

lietava commented Dec 19, 2024

@shahor02 : thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants