Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12395 Replaced kRainbow with kRainBow for consistency in PostTrackExtension macro #13866

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

Yuvrajsinghspd09
Copy link
Contributor

No description provided.

Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@f3sch
Copy link
Collaborator

f3sch commented Jan 16, 2025

Hi @Yuvrajsinghspd09, for sure we can merge this as this is anyways an untested macro. Maybe help me understand what consistency is achieved with this as kRainbow=kRainBow?

@Yuvrajsinghspd09
Copy link
Contributor Author

Hi @Yuvrajsinghspd09, for sure we can merge this as this is anyways an untested macro. Maybe help me understand what consistency is achieved with this as kRainbow=kRainBow?

Hi @f3sch, thank you for your feedback! I noticed one instance where kRainbow was written with a lowercase "b," so I updated it to the camel case version kRainBow to keep things consistent with the rest of the codebase. Since this is a very minor change, I thought testing might not be necessary, especially as the macro setup appears a bit complex.

Please let me know if there’s anything else I can clarify or improve. Thank you!

@mconcas mconcas merged commit 98dc521 into AliceO2Group:dev Jan 17, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants