Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1056] bookkeeping error page #1820

Merged
merged 11 commits into from
Jan 16, 2025

Conversation

hattinf
Copy link
Collaborator

@hattinf hattinf commented Dec 17, 2024

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:
-redirects to error page when page parameter is unknown

Notable changes for developers:

Changes made to the database:

@hattinf hattinf self-assigned this Dec 17, 2024
@hattinf hattinf changed the title Hattinf/o2 b 1056/bookkeeping error page [O2B-1056] bookkeeping error page Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 44.00%. Comparing base (86f5f39) to head (8755271).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/public/Model.js 0.00% 12 Missing ⚠️
lib/public/views/Error/ErrorModel.js 0.00% 10 Missing ⚠️
lib/public/views/Error/index.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1820      +/-   ##
==========================================
- Coverage   44.06%   44.00%   -0.07%     
==========================================
  Files         889      891       +2     
  Lines       15869    15892      +23     
  Branches     2993     2997       +4     
==========================================
  Hits         6993     6993              
- Misses       8876     8899      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/public/views/Error/ErrorModel.js Outdated Show resolved Hide resolved
lib/public/Model.js Outdated Show resolved Hide resolved
lib/public/views/Error/index.js Outdated Show resolved Hide resolved
lib/public/views/Error/index.js Outdated Show resolved Hide resolved
test/public/error/error.test.js Outdated Show resolved Hide resolved
test/public/error/error.test.js Outdated Show resolved Hide resolved
@hattinf hattinf requested a review from martinboulais January 8, 2025 10:38
lib/public/views/Error/ErrorModel.js Outdated Show resolved Hide resolved
lib/public/views/Error/index.js Outdated Show resolved Hide resolved
lib/public/Model.js Outdated Show resolved Hide resolved
lib/public/views/Error/index.js Outdated Show resolved Hide resolved
@hattinf hattinf requested a review from martinboulais January 13, 2025 15:26
@martinboulais martinboulais merged commit e54eaec into main Jan 16, 2025
21 of 23 checks passed
@martinboulais martinboulais deleted the hattinf/O2B-1056/bookkeeping-error-page branch January 16, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants