Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OCTRL-842] Make sure the consul path work with apricot backend #79

Merged
merged 2 commits into from
Feb 12, 2024
Merged

[OCTRL-842] Make sure the consul path work with apricot backend #79

merged 2 commits into from
Feb 12, 2024

Conversation

Barthelemy
Copy link
Collaborator

No description provided.

@Barthelemy Barthelemy requested a review from awegrzyn February 9, 2024 08:39
awegrzyn
awegrzyn approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@awegrzyn awegrzyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did you run tests by hand? In order to do it you need to remove L22 and set correct APRICOT_ENDPOINT

@Barthelemy
Copy link
Collaborator Author

I tested locally against staging.
I addressed the case you told me in MM: if there is a leaading / before o2/ it should also remove it.

@awegrzyn awegrzyn self-requested a review February 9, 2024 15:24
@Barthelemy Barthelemy merged commit ef49378 into AliceO2Group:master Feb 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awegrzyn awegrzyn awegrzyn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Barthelemy @awegrzyn