Align hook calls to follow the changes in OCTRL-902 #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OCTRL-902 allows to place hooks before or after SOSOR, EOSOR, SOEOR and EOEOR timestamps are created. This PR moves the hook triggers so that the order of plugin execution is preserved and the information the plugins need is still available. Calls which are critical for a successful SOR and EOR are placed inside the SOSOR - EOEOR timestamp boundaries. Similarly, some other calls at after_<event>+0 are moved to after_<event>-1 to contribute to the transition, even if technically it does not change the perceived behaviour at the moment.
knopers8
changed the title
knopers8
changed the title
teo
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCTRL-902 allows to place hooks before or after SOSOR, EOSOR, SOEOR and EOEOR timestamps are created. This PR moves the hook triggers so that the order of plugin execution is preserved and the information the plugins need is still available. Calls which are critical for a successful SOR and EOR are placed inside the SOSOR - EOEOR timestamp boundaries. Similarly, some other calls at
after_<event>+0are moved toafter_<event>-1to contribute to the transition, even if technically it does not change the perceived behaviour at the moment.