Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PWGCF] Update analysis structure and add centrality dependence #9082

Merged
merged 5 commits into from
Jan 6, 2025
Merged

[PWGCF] Update analysis structure and add centrality dependence #9082

merged 5 commits into from
Jan 6, 2025

Conversation

omassen
Copy link
Contributor

@omassen omassen commented Dec 20, 2024

Updated the structure of the analysis task to a more realistic one. Changed the output structure, using folders for the A- and C-side of the ZDC. In addition also implemented centrality dependence for more histograms.

See for a full history of recent changes this closed PR: #9045

@github-actions github-actions bot added the pwgcf label Dec 20, 2024
@github-actions github-actions bot changed the title Update analysis structure and add centrality dependence [PWGCF] Update analysis structure and add centrality dependence Dec 20, 2024
@victor-gonzalez
Copy link
Collaborator

Please, rename your executable to neutron-proton-corr-zdc in CMakeLists.txt to adhere to linter rules

@omassen omassen marked this pull request as ready for review December 20, 2024 15:37
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 2b28fd8 at 2024-12-20 17:38:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:113:34: error: 'std::__cxx11::basic_string<char>::<unnamed union> std::__cxx11::basic_string<char>::<anonymous>' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:113:34: error: 'char std::__cxx11::basic_string<char>::<unnamed union>::_M_local_buf [16]' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:113:34: error: 'std::__cxx11::basic_string<char>::<unnamed union> std::__cxx11::basic_string<char>::<anonymous>' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:113:34: error: 'char std::__cxx11::basic_string<char>::<unnamed union>::_M_local_buf [16]' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:113:34: error: 'std::__cxx11::basic_string<char>::<unnamed union> std::__cxx11::basic_string<char>::<anonymous>' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:113:34: error: 'char std::__cxx11::basic_string<char>::<unnamed union>::_M_local_buf [16]' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:113:34: error: 'std::__cxx11::basic_string<char>::<unnamed union> std::__cxx11::basic_string<char>::<anonymous>' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:113:34: error: 'char std::__cxx11::basic_string<char>::<unnamed union>::_M_local_buf [16]' is private within this context
ninja: build stopped: subcommand failed.

Full log here.

@victor-gonzalez
Copy link
Collaborator

Check O2Physics/Tutorials/src/histogramRegistry.cxx for guidance

@alibuild
Copy link
Collaborator

alibuild commented Jan 6, 2025

Error while checking build/O2Physics/o2 for f45b62e at 2025-01-06 12:15:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:114:34: error: 'std::__cxx11::basic_string<char>::<unnamed union> std::__cxx11::basic_string<char>::<anonymous>' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:114:34: error: 'char std::__cxx11::basic_string<char>::<unnamed union>::_M_local_buf [16]' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:114:34: error: 'std::__cxx11::basic_string<char>::<unnamed union> std::__cxx11::basic_string<char>::<anonymous>' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:114:34: error: 'char std::__cxx11::basic_string<char>::<unnamed union>::_M_local_buf [16]' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:114:34: error: 'std::__cxx11::basic_string<char>::<unnamed union> std::__cxx11::basic_string<char>::<anonymous>' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:114:34: error: 'char std::__cxx11::basic_string<char>::<unnamed union>::_M_local_buf [16]' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:114:34: error: 'std::__cxx11::basic_string<char>::<unnamed union> std::__cxx11::basic_string<char>::<anonymous>' is private within this context
/sw/SOURCES/O2Physics/9082-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx:114:34: error: 'char std::__cxx11::basic_string<char>::<unnamed union>::_M_local_buf [16]' is private within this context
ninja: build stopped: subcommand failed.

Full log here.

@omassen
Copy link
Contributor Author

omassen commented Jan 6, 2025

I fixed the build issues. It took a bit longer as I did not experience these problems locally, but it should be all good now!

victor-gonzalez
victor-gonzalez reviewed Jan 6, 2025
View reviewed changes
PWGCF/TwoParticleCorrelations/Tasks/neutronProtonCorrZdc.cxx
histos.fill(HIST(SubDir[side]) + HIST("CentvsZNSector1Signal"), centr, znEnergyResponse[side][1]);
histos.fill(HIST(SubDir[side]) + HIST("CentvsZNSector2Signal"), centr, znEnergyResponse[side][2]);
histos.fill(HIST(SubDir[side]) + HIST("CentvsZNSector3Signal"), centr, znEnergyResponse[side][3]);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point you can consider using a static constexpr array of std::string_view for encoding the names of the four sectors histograms and simplify this code

@victor-gonzalez victor-gonzalez merged commit bc31718 into AliceO2Group:master Jan 6, 2025
12 of 13 checks passed
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Jan 11, 2025
@omassen
[PWGCF] Update analysis structure and add centrality dependence (Alic…
ba32ab8 
…eO2Group#9082)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victor-gonzalez victor-gonzalez victor-gonzalez approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@saganatt saganatt Awaiting requested review from saganatt saganatt is a code owner

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

Assignees
No one assigned
Labels
pwgcf
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omassen @victor-gonzalez @alibuild