Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PWGHF] Added info for efficiency computation in PbPb for D+ #9142

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

[PWGHF] Added info for efficiency computation in PbPb for D+ #9142

wants to merge 12 commits into from
+407 −47

Conversation

Marcellocosti
Copy link
Contributor

The following axes have been added to the existing THnSparses present in taskDplus.cxx:

  • collision centrality
  • occupancy
  • B mother pt (for nonprompt candidates)
  • B mother pdg (for nonprompt candidates)

Plus, a dedicated sparse histogram for the information on the generated D+ candidates is added.

@github-actions github-actions bot added the pwghf PWG-HF label Dec 27, 2024
@alibuild alibuild mentioned this pull request Dec 27, 2024
Merged
@alibuild alibuild mentioned this pull request Dec 27, 2024
Merged
@Marcellocosti
Merge pull request #4 from alibuild/alibot-cleanup-9142
b8ccd33 
Please consider the following formatting changes to AliceO2Group#9142
vkucera
vkucera reviewed Dec 27, 2024
View reviewed changes
PWGHF/D2H/Tasks/taskDplus.cxx Show resolved Hide resolved
PWGHF/D2H/Tasks/taskDplus.cxx Outdated Show resolved Hide resolved
@Marcellocosti
Copy link
Contributor Author

Thank you @vkucera for the suggestions, I have however some curiosities for the future. Thank you in advance!

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for e9bddd3 at 2024-12-30 16:04:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9142-slc9_x86-64/0/PWGHF/D2H/Tasks/taskDplus.cxx:700:41: error: unused parameter 'mcRecoParticles' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/9142-slc9_x86-64/0/PWGHF/D2H/Tasks/taskDplus.cxx:710:53: error: unused parameter 'mcRecoParticles' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

vkucera
vkucera reviewed Jan 2, 2025
View reviewed changes
PWGHF/D2H/Tasks/taskDplus.cxx
Comment on lines +119 to +120
AxisSpec thnAxisY = {thnConfigAxisY, "y"};
AxisSpec thnAxisMlScore0 = {thnConfigAxisMlScore0, "Score 0"};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please

  • fix the names of the axes ptbins, massbins,
  • fix the casting (std::vector<double>)binsPt to static_cast<std::vector<double>>(binsPt).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkucera vkucera vkucera left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pwghf PWG-HF
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Marcellocosti @alibuild @vkucera