Skip to content

Commit

Permalink
[Common] fixed computation of output quality for ReferenceComparatorC…
Browse files Browse the repository at this point in the history
…heck (#2389)

In the current code the output quality was always Null because
the initial Null value is always not better than any other quality
from the plots analysis.
  • Loading branch information
aferrero2707 authored Aug 19, 2024
1 parent 98fca14 commit 01aff51
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Modules/Common/src/ReferenceComparatorCheck.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,8 @@ Quality ReferenceComparatorCheck::check(std::map<std::string, std::shared_ptr<Mo
continue;
}

// update the overall quality
if (quality.isWorseThan(result)) {
// initialize or update the overall quality
if (result == Quality::Null || quality.isWorseThan(result)) {
result.set(quality);
}

Expand Down

0 comments on commit 01aff51

Please sign in to comment.