-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QC-1248 Document QO->Flag conversion #2481
Conversation
FYI @JianLIUhep . These are basically my slides about QC flag conversion in form of markdown documentation. Please let me know if there is anything unclear in this doc from your point of view and feel free to refer detector experts to it once the PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was also not happy about it and I investigated what could be done. In Github you can have two versions of images for light and dark mode, but that requires generating the alternative ones and I wasn't motivated enough. I also could not manage to enforce a background in SVG through libre office. Also, github does not have a way to enforce a white background for transparent images. So I might still motivate myself to generate dark mode alternatives, seeing that I am not the only one who would suffer from this. |
Let @Barthelemy decide :) |
Never! |
Hi, Is the first image ok for you @justonedev1 ? I added a white background via the |
All of them, I just did printscreen of the first one |
It works for me (I also use dark mode). Thanks for the hack, I will apply it to the rest of the svgs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! thanks
ok, I will do the others |
oh you did it, thank you ! |
No description provided.