Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC-1248 Document QO->Flag conversion #2481

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

knopers8
Copy link
Collaborator

No description provided.

@knopers8
Copy link
Collaborator Author

FYI @JianLIUhep . These are basically my slides about QC flag conversion in form of markdown documentation. Please let me know if there is anything unclear in this doc from your point of view and feel free to refer detector experts to it once the PR is merged.

Copy link
Collaborator

@justonedev1 justonedev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a small issue with the images. As a casual Dark theme enjoyer, I really cannot see description and axis on the images, because you created the images with transparent background. I think, that I might not be the only one who might encounter this problem.
image

@knopers8
Copy link
Collaborator Author

Yes, I was also not happy about it and I investigated what could be done. In Github you can have two versions of images for light and dark mode, but that requires generating the alternative ones and I wasn't motivated enough. I also could not manage to enforce a background in SVG through libre office. Also, github does not have a way to enforce a white background for transparent images.

So I might still motivate myself to generate dark mode alternatives, seeing that I am not the only one who would suffer from this.

@justonedev1
Copy link
Collaborator

Let @Barthelemy decide :)

@knopers8
Copy link
Collaborator Author

Let @Barthelemy decide :)

Never!

@Barthelemy
Copy link
Collaborator

Hi,

Is the first image ok for you @justonedev1 ? I added a white background via the style attribute of the svg tag. `

@justonedev1
Copy link
Collaborator

All of them, I just did printscreen of the first one

@knopers8
Copy link
Collaborator Author

knopers8 commented Nov 22, 2024

Hi,

Is the first image ok for you @justonedev1 ? I added a white background via the style attribute of the svg tag. `

It works for me (I also use dark mode).

Thanks for the hack, I will apply it to the rest of the svgs.

Copy link
Collaborator

@justonedev1 justonedev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks

@Barthelemy
Copy link
Collaborator

ok, I will do the others

@Barthelemy
Copy link
Collaborator

oh you did it, thank you !

@Barthelemy Barthelemy merged commit a85844d into AliceO2Group:master Nov 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants