Fix warnings and errors that can be auto-fixed

Control/config-default.js

@@ -6,26 +6,26 @@ module.exports = {
     // key: './cert/key.pem',
     // cert: './cert/cert.pem',
     tls: false,
-    limit: '1Mb'
+    limit: '1Mb',
   },
   grpc: {
     hostname: 'localhost',
     port: 9090,
     timeout: 20000, // ms, gRPC deadline for service calls
     maxMessageLength: 50, // MB, gRPC receive message limit
     label: 'Control',
-    package: 'o2control'
+    package: 'o2control',
   },
   apricot: {
     hostname: 'localhost',
     port: 9090,
     timeout: 20000, // ms, gRPC deadline for service calls
     maxMessageLength: 50, // MB, gRPC receive message limit
     label: 'Apricot',
-    package: 'apricot'
+    package: 'apricot',
   },
   grafana: {
-    url: 'http://localhost:3000'
+    url: 'http://localhost:3000',
   },
   bookkeeping: {
     url: 'http://localhost:4000',
@@ -51,7 +51,7 @@ module.exports = {
     url: 'localhost:8083',
   },
   qcGui: {
-    url: 'qcg.cern.ch'
+    url: 'qcg.cern.ch',
   },
   utils: {
     refreshTask: 10000, // how often should task list page should refresh its content

Control/index.js

@@ -10,20 +10,20 @@
  * In applying this license CERN does not waive the privileges and immunities
  * granted to it by virtue of its status as an Intergovernmental Organization
  * or submit itself to any jurisdiction.
-*/
+ */
 
 const path = require('path');
-const {HttpServer, WebSocket} = require('@aliceo2/web-ui');
+const { HttpServer, WebSocket } = require('@aliceo2/web-ui');
 
 const config = require('./lib/config/configProvider.js');
-const {buildPublicConfig} = require('./lib/config/publicConfigProvider.js');
+const { buildPublicConfig } = require('./lib/config/publicConfigProvider.js');
 const api = require('./lib/api.js');
 
 // -------------------------------------------------------
 
 buildPublicConfig(config);
 
-config.http.iframeCsp = (config?.grafana?.url) ? [ config.grafana.url ] : [];
+config.http.iframeCsp = config?.grafana?.url ? [config.grafana.url] : [];
 const http = new HttpServer(config.http, config.jwt, config.openId);
 const ws = new WebSocket(http);
 http.addStaticPath(path.join(__dirname, 'public'));

Control/lib/adapters/EnvironmentInfoAdapter.js

@@ -11,20 +11,21 @@
  * or submit itself to any jurisdiction.
  */
 
-const {TaskState} = require('./../common/taskState.enum.js');
+const { TaskState } = require('./../common/taskState.enum.js');
+
 const QC_NODES_NAME_REGEX = /alio2-cr1-q(c|me|ts)[0-9]{2}/;
 
 /**
  * Enum with potential sources of tasks for AliECS environment
  * @readonly
- * @enum {String}
+ * @enum {string}
  */
 const TASKS_SOURCE = {
   EPN: 'EPN',
   FLP: 'FLP',
   TRG: 'TRG',
   QC: 'QC',
-}
+};
 
 /**
  * EnvironmentInfoAdapter - Given an AliECS Environment, construct an EnvironmentInfo object for GUI purposes
@@ -38,10 +39,10 @@ class EnvironmentInfoAdapter {
 
   /**
    * Converts the given proto object (o2control.proto) to an entity overview object.
-   *
    * @param {EnvironmentInfoProto} protoObject - object to convert
-   * @param {Array<String>} detectorsAll - list of all detectors in the current AliECS deployment
-   * @param {Map<String, Array<String>>} hostsByDetector - object with list of hosts grouped by detector
+   * @param environment
+   * @param {Array<string>} detectorsAll - list of all detectors in the current AliECS deployment
+   * @param {Map<string, Array<string>>} hostsByDetector - object with list of hosts grouped by detector
    * @returns {EnvironmentInfo} entity of environment with needed information
    */
   static toOverviewEntity(environment, detectorsAll, hostsByDetector) {
@@ -93,51 +94,49 @@ class EnvironmentInfoAdapter {
   /**
    * Method to build an environment info with tasks from specified source
    * @param {EnvironmentInfoProto} environment - environment as from AliECS
-   * @param {String} taskSource - source of tasks
-   * @param {Array<String>} detectorsAll - list of all detectors in the current AliECS deployment
-   * @param {Map<String, Array<String>>} hostsByDetectors - object with list of hosts grouped by detector
+   * @param {string} taskSource - source of tasks
+   * @param {Array<string>} detectorsAll - list of all detectors in the current AliECS deployment
+   * @param {Map<string, Array<string>>} hostsByDetectors - object with list of hosts grouped by detector
    */
   static toEntity(environment, taskSource = '', detectorsAll, hostsByDetectors) {
     taskSource = taskSource.toLocaleUpperCase();
 
     const environmentInfo = EnvironmentInfoAdapter.toOverviewEntity(environment, detectorsAll, hostsByDetectors);
     if (taskSource === TASKS_SOURCE.EPN) {
-      const {integratedServicesData: {odc = '{}'}} = environment;
-      const {devices = []} = JSON.parse(odc);
+      const { integratedServicesData: { odc = '{}' } } = environment;
+      const { devices = [] } = JSON.parse(odc);
 
-      environmentInfo.tasks = Array.from(
-        Object.values(devices).map((device) => {
-          device.epnState = device.state;
-          device.state = device.ecsState;
-          delete device.ecsState;
-          return device;
-        })
-      );
+      environmentInfo.tasks = Array.from(Object.values(devices).map((device) => {
+        device.epnState = device.state;
+        device.state = device.ecsState;
+        delete device.ecsState;
+        return device;
+      }));
     } else if (taskSource === TASKS_SOURCE.FLP) {
-      const {tasks = [], includedDetectors} = environment;
+      const { tasks = [], includedDetectors } = environment;
       environmentInfo.tasks = [];
       for (const task of tasks) {
-        const {deploymentInfo: {hostname = ''} = {}} = task;
+        const { deploymentInfo: { hostname = '' } = {} } = task;
         const keyDetector = Object.keys(Object.fromEntries(hostsByDetectors))
           .filter((detector) => hostsByDetectors.get(detector).includes(hostname))[0];
         if (!hostname.match(QC_NODES_NAME_REGEX) && includedDetectors.includes(keyDetector)) {
           environmentInfo.tasks.push(task);
         }
       }
     } else if (taskSource === TASKS_SOURCE.QC) {
-      const {tasks = []} = environment;
+      const { tasks = [] } = environment;
       environmentInfo.tasks = [];
       for (const task of tasks) {
-        const {deploymentInfo: {hostname = ''} = {}} = task;
+        const { deploymentInfo: { hostname = '' } = {} } = task;
         if (hostname.match(QC_NODES_NAME_REGEX)) {
           environmentInfo.tasks.push(task);
         }
       }
     } else if (taskSource === TASKS_SOURCE.TRG) {
-      const {tasks = [], includedDetectors} = environment;
+      const { tasks = [], includedDetectors } = environment;
       environmentInfo.tasks = [];
       for (const task of tasks) {
-        const {deploymentInfo: {hostname = ''} = {}} = task;
+        const { deploymentInfo: { hostname = '' } = {} } = task;
         const keyDetector = Object.keys(Object.fromEntries(hostsByDetectors))
           .filter((detector) => hostsByDetectors.get(detector).includes(hostname))[0];
         if (!hostname.match(QC_NODES_NAME_REGEX) && !includedDetectors.includes(keyDetector)) {
@@ -151,7 +150,7 @@ class EnvironmentInfoAdapter {
   /**
    * Given an environment, group its tasks by the 3 main categories: FLP, QC Nodes and CTP Readout
    * @param {EnvironmentInfo} environment - DTO representing an environment
-   * @param {Map<String, Array<String>>} hostsByDetectors - hosts grouped by the detectors
+   * @param {Map<string, Array<string>>} hostsByDetectors - hosts grouped by the detectors
    * @returns {object{tasks: Array<TaskInfo>, hosts: Set}} - Object with groups of tasks and set of unique hosts
    */
   static _getHardwareCountersPerComponent(environment, hostsByDetectors) {
@@ -171,31 +170,31 @@ class EnvironmentInfoAdapter {
     const trgStates = {};
     const trgStatuses = {};
 
-    const {tasks = [], includedDetectors = []} = environment;
+    const { tasks = [], includedDetectors = [] } = environment;
 
     for (const task of tasks) {
-      const {critical = false, status = 'NOT-KNOWN', deploymentInfo: {hostname = ''} = {}} = task;
-      let {state = TaskState.UNKNOWN} = task;
+      const { critical = false, status = 'NOT-KNOWN', deploymentInfo: { hostname = '' } = {} } = task;
+      let { state = TaskState.UNKNOWN } = task;
 
       if (state === TaskState.ERROR && critical) {
         state = TaskState.ERROR_CRITICAL;
       }
 
       if (hostname.match(QC_NODES_NAME_REGEX)) {
         qcTasksTotal++;
-        qcStates[state] = (qcStates[state] + 1) || 1;
-        qcStatuses[status] = (qcStatuses[status] + 1) || 1;
+        qcStates[state] = qcStates[state] + 1 || 1;
+        qcStatuses[status] = qcStatuses[status] + 1 || 1;
         qcHosts.add(hostname);
       } else {
-        const {userVars: {ctp_readout_enabled = 'false'} = {}} = environment;
+        const { userVars: { ctp_readout_enabled = 'false' } = {} } = environment;
         const isReadoutEnabled = ctp_readout_enabled === 'true';
 
         const keyDetector = Object.keys(Object.fromEntries(hostsByDetectors))
           .filter((detector) => hostsByDetectors.get(detector).includes(hostname))[0];
         if (includedDetectors.includes(keyDetector)) {
           flpTasksTotal++;
-          flpStates[state] = (flpStates[state] + 1) || 1;
-          flpStatuses[status] = (flpStatuses[status] + 1) || 1;
+          flpStates[state] = flpStates[state] + 1 || 1;
+          flpStatuses[status] = flpStatuses[status] + 1 || 1;
           if (!flpDetectors[keyDetector]) {
             flpDetectors[keyDetector] = {
               total: 0,
@@ -204,14 +203,14 @@ class EnvironmentInfoAdapter {
             };
           }
           flpDetectors[keyDetector].total++;
-          flpDetectors[keyDetector].states[state] = (flpDetectors[keyDetector].states[state] + 1) || 1;
-          flpDetectors[keyDetector].statuses[status] = (flpDetectors[keyDetector].statuses[status] + 1) || 1;
+          flpDetectors[keyDetector].states[state] = flpDetectors[keyDetector].states[state] + 1 || 1;
+          flpDetectors[keyDetector].statuses[status] = flpDetectors[keyDetector].statuses[status] + 1 || 1;
 
           flpHosts.add(hostname);
         } else if (isReadoutEnabled) {
           trgTasksTotal++;
-          trgStates[state] = (trgStates[state] + 1) || 1;
-          trgStatuses[status] = (trgStatuses[status] + 1) || 1;
+          trgStates[state] = trgStates[state] + 1 || 1;
+          trgStatuses[status] = trgStatuses[status] + 1 || 1;
           trgHosts.add(hostname);
         }
       }
@@ -234,42 +233,44 @@ class EnvironmentInfoAdapter {
         },
         hosts: flpHosts.size,
         detectorCounters: flpDetectors,
-      }, trg: {
+      },
+      trg: {
         tasks: {
           total: trgTasksTotal,
           states: trgStates,
           statuses: trgStatuses,
         },
         hosts: trgHosts.size,
-      }
+      },
     };
   }
 
   /**
    * Prepare an ODC object with hardware information based
-   * @param {Map<String, Object>} integratedServicesData - object with details of the integrated services
+   * @param {Map<string, object>} integratedServicesData - object with details of the integrated services
+   * @param odc
    */
   static _getOdcCounters(odc = {}) {
     try {
       /**
        * @type {Array<DeviceInfo>} devices
        */
-      const {devices = [], ddsSessionId = '', ddsSessionStatus = '', state = ''} = JSON.parse(odc);
+      const { devices = [], ddsSessionId = '', ddsSessionStatus = '', state = '' } = JSON.parse(odc);
       const states = {};
       const hosts = new Set();
 
       Object.values(devices).forEach((device) => {
-        const {ecsState, host} = device;
+        const { ecsState, host } = device;
         hosts.add(host);
-        states[ecsState] = (states[ecsState] + 1) || 1;
+        states[ecsState] = states[ecsState] + 1 || 1;
       });
       return {
         tasks: {
           total: Object.keys(devices).length,
-          states
+          states,
         },
         hosts: hosts.size,
-        info: {ddsSessionId, ddsSessionStatus, state}
+        info: { ddsSessionId, ddsSessionStatus, state },
       };
     } catch (error) {
       return {
@@ -278,7 +279,7 @@ class EnvironmentInfoAdapter {
           states: {},
         },
         hosts: 0,
-        info: {ddsSessionId: '-', ddsSessionStatus: '-', state: '-'}
+        info: { ddsSessionId: '-', ddsSessionStatus: '-', state: '-' },
       };
     }
   }
@@ -289,18 +290,20 @@ class EnvironmentInfoAdapter {
    * * remove any variables that are a detector variable but are not part of the included detector
    * @param {JSON} objectToFilterFrom - object from which var
    * @param {string} label
-   * @return {JSON}
+   * @param includedDetectors
+   * @param detectors
+   * @returns {JSON}
    */
   static _filterOutDetectorsVariables(objectToFilterFrom, includedDetectors, detectors) {
     const data = JSON.parse(JSON.stringify(objectToFilterFrom));
     for (const key of Object.keys(data)) {
       const prefixUpper = key.split('_')[0].toLocaleUpperCase();
       const isVariableDetector =
-        detectors.findIndex((det) => det.toLocaleUpperCase() === prefixUpper) !== -1
+        detectors.findIndex((det) => det.toLocaleUpperCase() === prefixUpper) !== -1;
       const isVariableIncludedDetector =
         includedDetectors.findIndex((det) => det.toLocaleUpperCase() === prefixUpper) !== -1;
       if (isVariableDetector && !isVariableIncludedDetector) {
-        delete data[key]
+        delete data[key];
       }
     }
     return data;

Control/lib/adapters/EnvironmentTransitionResultAdapter.js

@@ -25,7 +25,7 @@ class EnvironmentTransitionResultAdapter {
    * Converts the given object to an entity object.
    * @static
    * @param {ControlEnvironmentReply} transitionResult - as from AliECS
-   * @return {EnvironmentTransitionResult} information on the transition result of the environment
+   * @returns {EnvironmentTransitionResult} information on the transition result of the environment
    */
   static toEntity(transitionResult) {
     const {

Control/lib/adapters/RunSummaryAdapter.js

@@ -23,8 +23,7 @@ class RunSummaryAdapter {
 
   /**
    * Converts the given object to an entity object.
-   *
-   * @param {Object} run - Run Entity as per Bookkeeping https://github.com/AliceO2Group/Bookkeeping/blob/main/lib/domain/entities/Run.js
+   * @param {object} run - Run Entity as per Bookkeeping https://github.com/AliceO2Group/Bookkeeping/blob/main/lib/domain/entities/Run.js
    * @returns {RunSummary} entity of a task with needed information
    */
   static toEntity(run) {
@@ -40,7 +39,7 @@ class RunSummaryAdapter {
       endTime,
     } = run;
 
-    let {detectors = []} = run;
+    let { detectors = [] } = run;
     if (typeof detectors === 'string') {
       detectors = detectors.split(',');
     }

Control/lib/adapters/TaskInfoAdapter.js

@@ -22,7 +22,6 @@ class TaskInfoAdapter {
 
   /**
    * Converts the given proto object (o2control.proto) to an entity object.
-   *
    * @param {TaskInfoProto} task - object to convert
    * @returns {TaskInfo} entity of a task with needed information
    */
@@ -62,7 +61,7 @@ class TaskInfoAdapter {
    * @returns {string} short name of the task
    */
   static getShortName(taskName) {
-    const regex = new RegExp(`tasks/.*@`);
+    const regex = new RegExp('tasks/.*@');
     const matchedTaskName = taskName.match(regex);
     if (matchedTaskName) {
       taskName = matchedTaskName[0].replace('tasks/', '').replace('@', '');