Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OGUI-1580] add middleware for detector matching user role #2683

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from

Conversation

pepijndik
Copy link
Collaborator

@pepijndik pepijndik commented Dec 2, 2024

Middleware for checking if a user has a matching detector role

  • Added User belongsToDetector

  • DetectorOwnership middleware

  • DetectorOwnershipMiddleware tests

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

@graduta graduta changed the title [OGUI-1580] addmiddlewarefordetectormatchinguserrole [OGUI-1580] add middleware for detector matching user role Dec 2, 2024
@pepijndik pepijndik requested a review from graduta December 3, 2024 08:15
@graduta graduta removed the tests label Dec 3, 2024
Check isRoleSufficient
Detector ownership can have higher role than it's detector. Test this behavior
@pepijndik pepijndik requested a review from graduta December 3, 2024 19:04
in URL detectorid is uppercase while in accesslist not so convert them to lower
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants