-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OGUI-1580] add middleware for detector matching user role #2683
Open
pepijndik
wants to merge
19
commits into
dev
Choose a base branch
from
feature/pep/OGUI-1580/Addmiddlewarefordetectormatchinguserrole
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[OGUI-1580] add middleware for detector matching user role #2683
pepijndik
wants to merge
19
commits into
dev
from
feature/pep/OGUI-1580/Addmiddlewarefordetectormatchinguserrole
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmatchinguserrole
* DetectorOwnership middleware * DetectorOwnershipMiddleware tests
graduta
changed the title
[OGUI-1580] addmiddlewarefordetectormatchinguserrole
[OGUI-1580] add middleware for detector matching user role
Dec 2, 2024
graduta
requested changes
Dec 2, 2024
Control/test/lib/middleware/mocha-detectorOwnership.middleware.test.js
Outdated
Show resolved
Hide resolved
graduta
requested changes
Dec 3, 2024
Check isRoleSufficient
…rmatchinguserrole
Detector ownership can have higher role than it's detector. Test this behavior
Converts string into Array, with basic checks
…Addmiddlewarefordetectormatchinguserrole
…rmatchinguserrole
in URL detectorid is uppercase while in accesslist not so convert them to lower
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Middleware for checking if a user has a matching detector role
Added User belongsToDetector
DetectorOwnership middleware
DetectorOwnershipMiddleware tests
I have JIRA issue created