Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore invalid URLs that cause urljoin to raise. #393

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jyasskin
Copy link

@jyasskin jyasskin commented Oct 8, 2022

This just copies the invalid URL into the markdown link verbatim instead
of trying to join it to the base URL.

jyasskin and others added 2 commits October 7, 2022 22:42
This just copies the invalid URL into the markdown link verbatim instead
of trying to join it to the base URL.
@Alir3z4 Alir3z4 self-requested a review December 22, 2023 22:31
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (099c4b8) 97.23% compared to head (4157f6f) 96.74%.

Files Patch % Lines
html2text/__init__.py 62.50% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
- Coverage   97.23%   96.74%   -0.50%     
==========================================
  Files          11       11              
  Lines        1122     1135      +13     
==========================================
+ Hits         1091     1098       +7     
- Misses         31       37       +6     
Flag Coverage Δ
unittests-3.10 96.74% <62.50%> (-0.50%) ⬇️
unittests-3.11 96.74% <62.50%> (-0.50%) ⬇️
unittests-3.12 96.74% <62.50%> (-0.50%) ⬇️
unittests-3.8 96.74% <62.50%> (-0.50%) ⬇️
unittests-3.9 96.74% <62.50%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants