Merge pull request #641 from l1b0k/fix/err

fix: return err after roll back
AliyunContainerService · Jun 7, 2024 · 23ef06f · 23ef06f
2 parents a8c731c + a52d2ad
commit 23ef06f
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/aliyun/client/ecs.go b/pkg/aliyun/client/ecs.go
@@ -77,6 +77,7 @@ func (a *OpenAPI) CreateNetworkInterface(ctx context.Context, opts ...CreateNetw
 
 	if err != nil {
 		rollBackFunc()
+		return nil, err
 	}
 
 	return FromCreateResp(resp), err
@@ -281,6 +282,7 @@ func (a *OpenAPI) AssignPrivateIPAddress(ctx context.Context, opts ...AssignPriv
 	})
 	if err != nil {
 		rollBackFunc()
+		return nil, err
 	}
 
 	ips, err := ip.ToIPAddrs(resp.AssignedPrivateIpAddressesSet.PrivateIpSet.PrivateIpAddress)
@@ -362,6 +364,7 @@ func (a *OpenAPI) AssignIpv6Addresses(ctx context.Context, opts ...AssignIPv6Add
 	})
 	if err != nil {
 		rollBackFunc()
+		return nil, err
 	}
 
 	ips, err := ip.ToIPAddrs(resp.Ipv6Sets.Ipv6Address)