Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop validate for ClusterDomain #550

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Jan 10, 2024

No description provided.

@l1b0k l1b0k requested a review from BSWANG January 10, 2024 13:19
@l1b0k l1b0k changed the title fix: drop validate for ClusterDomain WIP fix: drop validate for ClusterDomain Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24cdbaa) 18.00% compared to head (fa12465) 17.93%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   18.00%   17.93%   -0.08%     
==========================================
  Files         105      105              
  Lines       13871    13871              
==========================================
- Hits         2498     2488      -10     
- Misses      11043    11053      +10     
  Partials      330      330              
Flag Coverage Δ
unittests 17.93% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@l1b0k l1b0k changed the title WIP fix: drop validate for ClusterDomain fix: drop validate for ClusterDomain Jan 11, 2024
@BSWANG BSWANG merged commit 87b8d85 into AliyunContainerService:main Jan 11, 2024
9 of 10 checks passed
@l1b0k l1b0k deleted the fix/validate branch January 11, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants