Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring the pool #551

Merged
merged 2 commits into from
Jan 15, 2024
Merged

refactoring the pool #551

merged 2 commits into from
Jan 15, 2024

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Jan 11, 2024

  • Allow pod level config to select eni
  • EIP feature is removed

@l1b0k l1b0k requested a review from BSWANG January 11, 2024 10:57
@l1b0k l1b0k force-pushed the feat/pool branch 5 times, most recently from a50f3c5 to c20680c Compare January 12, 2024 07:28
- Allow pod level config to select eni
- EIP feature is removed
- Improved CNI performance

Signed-off-by: l1b0k <[email protected]>
Signed-off-by: l1b0k <[email protected]>
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 2531 lines in your changes are missing coverage. Please review.

Comparison is base (87b8d85) 17.93% compared to head (e2942ec) 18.43%.

Files Patch % Lines
pkg/eni/local.go 5.04% 601 Missing and 1 partial ⚠️
daemon/daemon.go 0.00% 462 Missing ⚠️
pkg/factory/aliyun/aliyun.go 0.00% 326 Missing ⚠️
pkg/k8s/k8s.go 0.00% 275 Missing ⚠️
pkg/eni/manager.go 37.96% 131 Missing and 3 partials ⚠️
pkg/eni/remote.go 27.45% 106 Missing and 5 partials ⚠️
pkg/aliyun/client/ecs.go 0.00% 103 Missing ⚠️
pkg/eni/types.go 30.47% 72 Missing and 1 partial ⚠️
pkg/aliyun/metadata/metadata.go 0.00% 64 Missing ⚠️
types/daemon/types.go 0.00% 47 Missing ⚠️
... and 29 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
+ Coverage   17.93%   18.43%   +0.49%     
==========================================
  Files         105      106       +1     
  Lines       13871    12234    -1637     
==========================================
- Hits         2488     2255     -233     
+ Misses      11053     9667    -1386     
+ Partials      330      312      -18     
Flag Coverage Δ
unittests 18.43% <7.89%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BSWANG BSWANG merged commit 0df4bf1 into AliyunContainerService:main Jan 15, 2024
9 of 10 checks passed
@l1b0k l1b0k deleted the feat/pool branch January 15, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants