Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check local pods before gc #552

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Jan 18, 2024

No description provided.

@l1b0k l1b0k requested a review from BSWANG January 18, 2024 02:12
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (0df4bf1) 18.43% compared to head (b1ffd5e) 18.41%.

Files Patch % Lines
pkg/k8s/k8s.go 0.00% 11 Missing ⚠️
daemon/daemon.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
- Coverage   18.43%   18.41%   -0.03%     
==========================================
  Files         106      106              
  Lines       12234    12248      +14     
==========================================
  Hits         2255     2255              
- Misses       9667     9681      +14     
  Partials      312      312              
Flag Coverage Δ
unittests 18.41% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BSWANG BSWANG merged commit 58d93a5 into AliyunContainerService:main Jan 18, 2024
8 of 10 checks passed
@l1b0k l1b0k deleted the fix/local_pod branch January 18, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants