Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing event #575

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Feb 27, 2024

No description provided.

@l1b0k l1b0k requested a review from BSWANG February 27, 2024 08:27
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 18.93%. Comparing base (be783c4) to head (14fcc19).

Files Patch % Lines
pkg/eni/manager.go 20.00% 3 Missing and 1 partial ⚠️
pkg/eni/local.go 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
+ Coverage   18.15%   18.93%   +0.77%     
==========================================
  Files         107      107              
  Lines       12456    12466      +10     
==========================================
+ Hits         2262     2360      +98     
+ Misses       9876     9781      -95     
- Partials      318      325       +7     
Flag Coverage Δ
unittests 18.93% <61.11%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BSWANG BSWANG merged commit ecdd975 into AliyunContainerService:main Feb 27, 2024
10 checks passed
@l1b0k l1b0k deleted the fix/missingevent branch February 28, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants