Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eni type check #576

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Feb 28, 2024

No description provided.

@l1b0k l1b0k requested a review from BSWANG February 28, 2024 03:36
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 18.93%. Comparing base (ecdd975) to head (61b7b37).

Files Patch % Lines
pkg/factory/aliyun/aliyun.go 0.00% 12 Missing ⚠️
pkg/eni/local.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #576   +/-   ##
=======================================
  Coverage   18.93%   18.93%           
=======================================
  Files         107      107           
  Lines       12466    12466           
=======================================
  Hits         2360     2360           
  Misses       9781     9781           
  Partials      325      325           
Flag Coverage Δ
unittests 18.93% <7.14%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: l1b0k <[email protected]>
@BSWANG BSWANG merged commit 8ddf95f into AliyunContainerService:main Feb 28, 2024
9 of 10 checks passed
@l1b0k l1b0k deleted the fix/enitype branch February 28, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants