Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: addon secret #577

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Feb 29, 2024

No description provided.

Reduce build product size

Signed-off-by: l1b0k <[email protected]>
@l1b0k l1b0k requested a review from BSWANG February 29, 2024 07:40
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 10.81081% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 18.93%. Comparing base (8ddf95f) to head (db84472).

Files Patch % Lines
types/daemon/config.go 14.81% 21 Missing and 2 partials ⚠️
pkg/utils/k8sclient/client.go 0.00% 4 Missing ⚠️
pkg/k8s/k8s.go 0.00% 3 Missing ⚠️
pkg/apis/crds/register.go 0.00% 2 Missing ⚠️
pkg/aliyun/credential/sts.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
+ Coverage   18.89%   18.93%   +0.03%     
==========================================
  Files         107      107              
  Lines       12466    12487      +21     
==========================================
+ Hits         2356     2364       +8     
- Misses       9784     9796      +12     
- Partials      326      327       +1     
Flag Coverage Δ
unittests 18.93% <10.81%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BSWANG BSWANG merged commit 5aa457b into AliyunContainerService:main Feb 29, 2024
9 of 10 checks passed
@l1b0k l1b0k deleted the feat/addon-secret branch February 29, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants