Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support eflo #578

Merged
merged 1 commit into from
Mar 5, 2024
Merged

feat: support eflo #578

merged 1 commit into from
Mar 5, 2024

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Mar 4, 2024

No description provided.

@l1b0k l1b0k requested a review from BSWANG March 4, 2024 03:49
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 6.52174% with 602 lines in your changes are missing coverage. Please review.

Project coverage is 18.58%. Comparing base (60ac6bc) to head (da0933c).

Files Patch % Lines
pkg/factory/aliyun/eflo.go 0.00% 209 Missing ⚠️
pkg/aliyun/client/eflo.go 0.00% 150 Missing ⚠️
pkg/aliyun/client/ecs.go 0.00% 61 Missing ⚠️
daemon/daemon.go 0.00% 55 Missing ⚠️
pkg/aliyun/instance/ecs.go 0.00% 31 Missing ⚠️
pkg/factory/aliyun/aliyun.go 0.00% 29 Missing ⚠️
pkg/aliyun/credential/aliyun_client_mgr.go 0.00% 24 Missing ⚠️
pkg/aliyun/client/limit.go 10.00% 18 Missing ⚠️
pkg/aliyun/instance/eflo_linux.go 0.00% 18 Missing ⚠️
types/config.go 33.33% 4 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
- Coverage   18.99%   18.58%   -0.42%     
==========================================
  Files         109      115       +6     
  Lines       12573    12975     +402     
==========================================
+ Hits         2388     2411      +23     
- Misses       9850    10230     +380     
+ Partials      335      334       -1     
Flag Coverage Δ
unittests 18.58% <6.52%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/aliyun/instance/public.go Outdated Show resolved Hide resolved
Signed-off-by: l1b0k <[email protected]>
@BSWANG BSWANG merged commit c2f8da7 into AliyunContainerService:main Mar 5, 2024
8 of 10 checks passed
@l1b0k l1b0k deleted the feat/eflo branch March 5, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants