Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip]feat: meni #645

Merged
merged 4 commits into from
Jul 18, 2024
Merged

[wip]feat: meni #645

merged 4 commits into from
Jul 18, 2024

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Jul 5, 2024

No description provided.

@l1b0k l1b0k requested a review from BSWANG July 5, 2024 09:20
@l1b0k l1b0k changed the title feat: meni [wip]feat: meni Jul 5, 2024
nodes.network.alibabacloud.com

Signed-off-by: l1b0k <[email protected]>
@l1b0k l1b0k force-pushed the feat/meni branch 3 times, most recently from 69e6dff to e1d3a85 Compare July 12, 2024 02:02
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 35.36940% with 1111 lines in your changes missing coverage. Please review.

Project coverage is 27.32%. Comparing base (677cd12) to head (ed641f3).
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/controller/multi-ip/node/pool.go 53.82% 284 Missing and 30 partials ⚠️
daemon/builder.go 5.99% 297 Missing and 1 partial ⚠️
pkg/eni/crdv2.go 0.00% 129 Missing ⚠️
pkg/eni/node_reconcile.go 0.00% 108 Missing ⚠️
daemon/daemon_linux.go 0.00% 67 Missing ⚠️
pkg/aliyun/client/limit.go 14.47% 65 Missing ⚠️
pkg/controller/node/node.go 64.92% 33 Missing and 14 partials ⚠️
pkg/aliyun/client/ecs.go 0.00% 29 Missing ⚠️
pkg/controller/node/predict.go 0.00% 20 Missing ⚠️
pkg/aliyun/client/ecs_options.go 51.72% 7 Missing and 7 partials ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
+ Coverage   23.61%   27.32%   +3.70%     
==========================================
  Files          62       71       +9     
  Lines        6491     7855    +1364     
==========================================
+ Hits         1533     2146     +613     
- Misses       4714     5407     +693     
- Partials      244      302      +58     
Flag Coverage Δ
unittests 27.32% <35.36%> (+3.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@l1b0k l1b0k force-pushed the feat/meni branch 3 times, most recently from 1f22593 to ff6e961 Compare July 16, 2024 09:37
@BSWANG BSWANG merged commit 3aba8b9 into AliyunContainerService:main Jul 18, 2024
9 checks passed
@l1b0k l1b0k deleted the feat/meni branch July 18, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants