Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controlplane: wait node has valid lables #669

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Aug 26, 2024

No description provided.

@l1b0k l1b0k requested a review from BSWANG August 26, 2024 11:26
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.11%. Comparing base (bb54e45) to head (3bcdaab).
Report is 7 commits behind head on main.

Files Patch % Lines
pkg/controller/node/predict.go 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
+ Coverage   27.52%   28.11%   +0.58%     
==========================================
  Files          78       78              
  Lines        8367     8480     +113     
==========================================
+ Hits         2303     2384      +81     
- Misses       5744     5765      +21     
- Partials      320      331      +11     
Flag Coverage Δ
unittests 28.11% <50.00%> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BSWANG BSWANG merged commit a3e477a into AliyunContainerService:main Aug 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants