Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pod uid check in cni add #704

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Oct 21, 2024

No description provided.

@l1b0k l1b0k requested a review from BSWANG October 21, 2024 03:31
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 20.30%. Comparing base (6a4a716) to head (239f5c9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/eni/crdv2.go 0.00% 4 Missing ⚠️
pkg/controller/multi-ip/node/pool.go 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
+ Coverage   20.27%   20.30%   +0.03%     
==========================================
  Files         125      125              
  Lines       17005    17017      +12     
==========================================
+ Hits         3447     3455       +8     
- Misses      13170    13176       +6     
+ Partials      388      386       -2     
Flag Coverage Δ
unittests 20.30% <57.14%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BSWANG BSWANG merged commit 5e402ef into AliyunContainerService:main Oct 21, 2024
9 checks passed
@l1b0k l1b0k deleted the feat/uid_check branch October 21, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants