Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and fix custom mek ore processing script. #357

Closed
wants to merge 3 commits into from

Conversation

plapik
Copy link

@plapik plapik commented Aug 29, 2024

Update kjs custom ore processing script so it works with new mekanism, and add just dire things metals processing.

Update and cleanup ore processing script, so it works
Add just dire things metals to mek ore processing
@djnifos
Copy link
Contributor

djnifos commented Aug 30, 2024

Our ATO metals already worked, besides for the JDT stuff, what problem are we trying to fix here?

@plapik
Copy link
Author

plapik commented Aug 30, 2024

Some parts of script were outdated and simply didn't work. For example in recipes slurry output was replaced with chemical one, outdated AlmostUnified method call (getPreferredItemForTag -> getTagTargetItem). Only reason why kubejs didn't show errors was fact that script was unused.

@djnifos
Copy link
Contributor

djnifos commented Aug 30, 2024

I guess my thoughts are that since the ores from ATO were already working, and we fixed the ATM ores last night, the entire script isn't necessary

@plapik
Copy link
Author

plapik commented Aug 30, 2024

If it isn't necessary, then please close this PR. Though it may be useful for mods added in future - for example this script was used for silent gear ores in previous ATM.

@whatthedrunk
Copy link
Member

Thanks a ton for the PR but will close it as asked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants