Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin/update-readme #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

admin/update-readme #44

wants to merge 2 commits into from

Conversation

heeler
Copy link
Member

@heeler heeler commented Dec 8, 2020

Changed Readme wording to make it slightly more precise.
Updated setup.py authors/emails

No code changes

Copy link
Contributor

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minus my one requested change, looks good to me.

Comment on lines +11 to +12
render-ready products for the cells in each field. This pipeline uses
accepted best practices (documentation, unit testing, and continuous integration).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "This pipeline uses accepted best practices (documentation, unit testing, and continuous integration)."

This is standard, not something to highlight.

Copy link
Contributor

@donovanr donovanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update @heeler. I think @JacksonMaxfield is right re: not belaboring the point that we try to do a good job with docs etc. but otherwise looks good.

@evamaxfield evamaxfield changed the title Update/readme admin/update-readme Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants