fix segment length rounding error #473 #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These failures seem to be related to pynwb/hdmf versions, not this PR - is that being addressed? |
|
Yes, a new release should be available soon |
|
@tmchartrand The pynwb/hdmf version issue was fixed with the 1.0.1 version released on September 16th. Based on your comment, is this PR still needed? |
|
@wbwakeman yes, definitely still needed. That previous comment was referring to the tests that were initially showing as failing for this PR, not the underlying issue, sorry it was unclear. |
tmchartrand
force-pushed
the
dat_conversion_bugfix
branch
from
e4b4e74 to
ea9950a
Compare
sgratiy
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #473
In the DAT converter, segments of sweeps are constructed with length calculated by floating point division. The result can be slightly less or greater than the the actual integer value, so applying math.trunc was dropping data points in some cases. This fixes the issue by rounding instead, and raises an error if the unrounded value is not close to an integer.