Replies: 2 comments
-
I tried to follow the original branch wherever possible and so I had the Species class inherit from the PIDName classes. If abbreviations aren't expected to be used, we can remove the inheritance and the abbreviation field. It makes sense to do that. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Cool - I'll add that to my PR. I get why it's there, but I think it'll just be cleaner since we won't use abbreviations here. Thanks! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Since we are no longer using the PIDName construct, is there a reason to keep the abbreviation field for the species classes when we aren't going to use it? @jtyoung84
Beta Was this translation helpful? Give feedback.
All reactions