Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use grpc.netty.shaded instead of grpc.netty #18650

Open
wants to merge 1 commit into
base: master-2.x
Choose a base branch
from

Conversation

jja725
Copy link
Contributor

@jja725 jja725 commented Jul 6, 2024

What changes are proposed in this pull request?

Use shaded netty since we can not rely on external netty dependency when integrating Alluxio with Trino codebase

Why are the changes needed?

grpc-netty-shaded is grpc-netty + netty + netty-tcnative all built into one jar. so grpc-netty-shaded allows using a compatible version of Netty without worrying about if Netty is a transitive dependency somewhere else in your app (since Netty is a pretty common dependency). It also is a benefit for vulnerabilities, as upgrading Netty can sometimes be difficult, but with grpc-netty-shaded you can upgrade for gRPC easily.

Does this PR introduce any user facing changes?

na

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant