Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetBranchByVolume #1318

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

abessiari
Copy link
Contributor

Made changed introduced in https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3157
The changes are as of now in master.

@abessiari
Copy link
Contributor Author

@ghweber

Please take a look and let me know how we can proceed.

@abessiari
Copy link
Contributor Author

@cyrush
cc @ghweber

Hi Cyrus can you please take a look at this PR? The changes to ascent are based on vtkm master branch.
Thanks

@cyrush
Copy link
Member

cyrush commented Aug 22, 2024

@abessiari Do you know if these changes are now in a release, such as 2.2?

@abessiari
Copy link
Contributor Author

abessiari commented Aug 22, 2024

@cyrush It looks like those changes are in vtkm 2.2.0. I will double check by testing against it. I have a doctor's appointment and I will confirm once I am back.

Thanks

@ghweber
Copy link
Contributor

ghweber commented Aug 22, 2024 via email

@abessiari
Copy link
Contributor Author

@cyrush
Yes vtkm tag v2.2.0 is fine. ascent code compiles and runs using Warpx.

Handling  multiple domains
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants