[최단 경로] 2176063 김서현 #353
Open
[최단 경로] 2176063 김서현 #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
코드리뷰완료 |
Dong-droid
reviewed
May 31, 2023
| #include <vector> | ||
|
|
||
| using namespace std; | ||
| const int CONNECTED = 1; |
There was a problem hiding this comment.
오! 이렇게 하니까 가독성이 더 좋은 것 같아요!! 배워갑니다~ 🦸
Dong-droid
reviewed
May 31, 2023
Comment on lines
+11
to
+12
| if(graph[i][k] && graph[k][j]) { // i가 k보다 작고, k가 j보다 작다 -> i가 j보다 작다 | ||
| graph[i][j] = CONNECTED; // 연결 표시 |
Dong-droid
reviewed
May 31, 2023
13_최단 경로/필수/2458.cpp
Outdated
| for(int i = 1; i <= n; i++) { | ||
| int cnt = 0; | ||
| for(int j = 1; j <= n; j++) { | ||
| if(graph[i][j] || graph[j][i]) { // 작거나 크다는 걸 알면 |
There was a problem hiding this comment.
P3. 이 반대의 경우에 break;를 하는 것도 좋은 방법일 것 같아요~ cnt는 for문의 끝에 도달했을 때 하나 올려주면 되고요~
Dong-droid
reviewed
May 31, 2023
13_최단 경로/필수/2458.cpp
Outdated
| if(graph[i][j] || graph[j][i]) { // 작거나 크다는 걸 알면 | ||
| cnt++; // 카운트 증가 | ||
|
|
||
| if(cnt >= n - 1) { // n-1명의 학생들에 연결되어있으면 |
There was a problem hiding this comment.
if(cnt == n-1)이어도 될 것 같아요~
Dong-droid
reviewed
May 31, 2023
Comment on lines
+36
to
+60
| int main() { | ||
| ios_base::sync_with_stdio(0); | ||
| cin.tie(0); | ||
| cout.tie(0); | ||
|
|
||
| int n, m, a, b; | ||
|
|
||
| // 입력 | ||
| cin >> n >> m; | ||
| vector<vector<int>> graph(n+1, vector<int>(n+1, 0)); | ||
|
|
||
| while(m--) { | ||
| cin >> a >> b; | ||
| graph[a][b] = CONNECTED; // 연결 표시 | ||
| } | ||
|
|
||
| // 연산 | ||
| floydWarshall(n, graph); // 플로이드 워셜 | ||
| int ans = findStudent(n, graph); // 키가 몇 번째인지 알 수 있는 학생 수 | ||
|
|
||
| // 출력 | ||
| cout << ans << '\n'; | ||
|
|
||
| return 0; | ||
| } |
Dong-droid
reviewed
May 31, 2023
| pq.push({0, start}); // 시간, 시작점 | ||
|
|
||
| while(!pq.empty()) { | ||
| int time = pq.top().first; // 지금 뽑힌 정점의 time |
There was a problem hiding this comment.
P3. time은 다른 언어에서 키워드인 것 같아요. 혹시 모르니까 조심하세요~
Dong-droid
reviewed
May 31, 2023
13_최단 경로/필수/1238.cpp
Outdated
| int ans = 0; | ||
|
|
||
| for(int i = 1; i <= n; i++) { | ||
| int time = dijkstra(i, x, n, graph) + dijkstra(x, i, n, graph); // 가는 시간 + 오는 시간 |
There was a problem hiding this comment.
P3. dijkstra(x,i,n,graph)는 한 번만 실행되도 되기 때문에 for문 전에 실행한 결과를 저장해 두고 사용하면 시간을 더 줄일 수 있을 거에요.
There was a problem hiding this comment.
dijkstra를 한 번만 실행하니까 시간이 두 배로 줄었어요..!! 감사합니다!
|
리뷰 해주신대로 수정하여 제출했습니다! 마지막까지 감사합니다 ❤ |
jk0527
reviewed
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
인적사항
학번: 2176063
이름: 김서현
과제 제출
기존 제출 : 1238, 2458
추가 제출 : 15681