[13 최단경로] 1914039 최유진 #358
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P1. 코드리뷰완료 |
Dong-droid
reviewed
May 31, 2023
| int Cost = -PQ.top().first; | ||
| int Cur = PQ.top().second; | ||
| PQ.pop(); //coast와 cur에 저장한 다음 pop | ||
|
|
There was a problem hiding this comment.
P1. 다익스트라의 핵심적인 부분이 빠졌습니다!!! 다른 문제의 경우에 이 부분을 빠뜨리면 시간 초과가 나는 경우가 많습니다. 다익스트라의 그리디 최적해는 최소 정점을 뽑고, 어떤 경우 ❓ 에 무시를 하게 됩니다! 이 를 어떻게 구현했었죠??
Dong-droid
reviewed
May 31, 2023
13_최단 경로/필수/1238.cpp
Outdated
Comment on lines
51
to
74
| void Solution() { | ||
|
|
||
| for (int i = 1; i <= N; i++) { | ||
| for (int j = 1; j <= N; j++) { | ||
| Dist[j] = INF; | ||
| } | ||
| Dijkstra(i); | ||
| Res[i] = Dist[X]; | ||
| } | ||
| for (int j = 1; j <= N; j++) { | ||
| Dist[j] = INF; | ||
| } | ||
|
|
||
| Dijkstra(X); | ||
| for (int i = 1; i <= N; i++) { | ||
| Res[i] = Res[i] + Dist[i]; | ||
| } | ||
|
|
||
| sort(Res + 1, Res + N + 1);// 가장 큰 값을 찾기 위해 정렬 | ||
| int Answer = Res[N];//가장 큰 값 | ||
|
|
||
| cout << Answer; | ||
| } | ||
|
|
There was a problem hiding this comment.
💯 P3. 그런데, 변수 이름에 Answer 이렇게 첫 문자만 대문자로 하는 이유가 있나요?? snake case와 camel case 둘다 아닌 것 같은데요!! answer로 하시는 게 클린 코드에 더 부합하는 것 같습니다 😉
jk0527
reviewed
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
인적사항
학번: 1914039
이름: 최유진
과제 제출
기존 제출 : 1238
추가 제출 : 2458, 15685