HTML snapshot test for all samples for consistency in the markup #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divdavem
changed the title
divdavem
force-pushed
the
htmlSnapshot
branch
4 times, most recently
from
71c3ec0
to
0286d85
Compare
divdavem
force-pushed
the
htmlSnapshot
branch
3 times, most recently
from
dbcb847
to
61f82a4
Compare
e2e/htmlSnapshot.ts
Outdated
| const cleanChildNodes = (childNodes: HTMLNode[]) => { | ||
| childNodes = [...childNodes]; | ||
| const result: HTMLNode[] = []; | ||
| for (let i = 0; i < childNodes.length; i++) { |
There was a problem hiding this comment.
Could this for loop not be rewritten using a while loop ?
while (childNodes.length) {
let newValue = childNodes.shift();
if (typeof newValue === 'string') {
const previousValue = result[result.length - 1];
if (typeof previousValue === 'string' ) {
result.pop();
newValue = previousValue + newValue;
} else if (newValue.tagName === '') {
childNodes.unshift(...newValue.childNoes);
continue;
}
result.push(newValue);
}
}
e2e/htmlSnapshot.ts
Outdated
| return null; | ||
| } | ||
| const tagName = node.tagName.toLowerCase(); | ||
| const textarea = isTextArea(node); |
There was a problem hiding this comment.
minor: could be renamed to isNodeArea or is isNodeTextArea to respect naming conventions on boolean variables
e2e/htmlSnapshot.ts
Outdated
| } | ||
| const tagName = node.tagName.toLowerCase(); | ||
| const textarea = isTextArea(node); | ||
| const childNodes: any[] = []; |
There was a problem hiding this comment.
could be typed to HTMLNode
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 82.48% 83.49% +1.01%
==========================================
Files 60 60
Lines 1781 1818 +37
Branches 347 362 +15
==========================================
+ Hits 1469 1518 +49
+ Misses 263 250 -13
- Partials 49 50 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@quentinderoubaix Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.