Server-side rendering with react #698
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #698 +/- ##
==========================================
- Coverage 92.72% 92.65% -0.07%
==========================================
Files 69 69
Lines 1992 2002 +10
Branches 367 368 +1
==========================================
+ Hits 1847 1855 +8
- Misses 77 78 +1
- Partials 68 69 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
divdavem
force-pushed
the
ssrReact
branch
2 times, most recently
from
af224f7
to
b104af0
Compare
| (directive: Directive): {ref: RefCallback<HTMLElement>}; | ||
| <T>(directive: Directive<T>, args: T): {ref: RefCallback<HTMLElement>}; | ||
| } = BROWSER | ||
| ? <T>(directive: Directive<T>, args?: T): {ref: RefCallback<HTMLElement>; suppressHydrationWarning: true} => { |
There was a problem hiding this comment.
I would rather keep the hydration warning than suppress it to be fair...
We can merge with that warning, but please create a GitHub issue to track this.
There was a problem hiding this comment.
I have opened #715 to track this.
|
@quentinderoubaix I have made the changes you requested. I am not at all satisfied with the reduced validation this implies (i.e. not running react SSR test in dev mode), but if it is ok for you, we can merge it like this and improve things later. I have added a comment in #315 about this. |
|
@quentinderoubaix Thank you! |
This PR is built on top of #697
It adds support for server-side rendering with react.