fix: the tsconfig spec generated for library contains several issues #2584

cpaulve-1A · 2024-12-12T14:58:03Z

Proposed change

Only use composite for library generated for workspace set up with jest.
Ensure path do not target any invalid files.

Related issues

🐛 Fix [Bug]: The tsconfig spec generated for library contains several issues #2481

nx-cloud · 2024-12-12T14:59:06Z

View your CI Pipeline Execution ↗ for commit eca073c.

Command	Status	Duration	Result
`nx run-many --target=test-int`	✅ Succeeded	1s	View ↗
`nx run-many --target=test-e2e`	✅ Succeeded	7m 50s	View ↗
`nx run-many --target=build --projects=eslint-pl...`	✅ Succeeded	<1s	View ↗
`nx run-many --target=publish --nx-bail --userco...`	✅ Succeeded	1m 48s	View ↗
`nx run-many --target=documentation`	✅ Succeeded	1m 19s	View ↗
`nx affected --target=test --collectCoverage`	✅ Succeeded	3s	View ↗
`nx run ama-sdk-schematics:build-swagger`	✅ Succeeded	<1s	View ↗
`nx run-many --target=build`	✅ Succeeded	21s	View ↗
`Additional runs (3)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-01-24 11:28:19 UTC

codecov · 2024-12-12T15:03:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.88%. Comparing base (bd1de82) to head (eca073c).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/@o3r/workspace/schematics/library/templates/ng/tsconfig.spec.json.template

packages/@o3r/workspace/schematics/library/index.ts

packages/@o3r/test-helpers/src/utilities/package-manager.ts

packages/@o3r/workspace/schematics/library/rules/rules.ng.ts

packages/@o3r/workspace/schematics/ng-add/helpers/npm-workspace.ts

packages/@o3r/test-helpers/src/utilities/package-manager.ts

packages/@o3r/workspace/schematics/library/index.spec.ts

packages/@o3r/workspace/schematics/library/rules/rules.nx.ts

packages/@o3r/workspace/schematics/library/rules/shared.ts

packages/@o3r/workspace/schematics/library/templates/ng/tsconfig.spec.json.template

vscaiceanu-1a

accoding to the comment, the lint can be reactivated in
packages/@o3r/eslint-config/schematics/index.it.spec.ts

packages/@o3r/components/schematics/index.it.spec.ts

packages/@o3r/workspace/package.json

matthieu-crouzet · 2025-01-23T10:31:43Z

packages/@o3r/testing/schematics/ng-add/index.ts

@@ -162,7 +164,8 @@ function ngAddFn(options: NgAddSchematicsSchema): Rule {

          const jestConfigFilesForWorkspace = () => mergeWith(apply(url('./templates/workspace'), [
            template({
-              ...options
+              ...options,
+              tsconfigPath: `./${['tsconfig.base.json', 'tsconfig.json'].find((tsconfigBase) => tree.exists(`./${tsconfigBase}`))}`


Could it happen that none are found ?

This is a recurring logic for our generators so I don't think anyone could use or generators if they don't have any of these files.
Actually, tsconfig.json is generated by angular create itself:

Only use composite for library generated for workspace set up with jest. Ensure path do not target any invalid files.

packages/@o3r/workspace/schematics/library/index.spec.ts

cpaulve-1A requested a review from a team as a code owner December 12, 2024 14:58

github-actions bot added bug Something isn't working project:@o3r/workspace project:new-version-gh-action labels Dec 12, 2024

fpaul-1A reviewed Dec 12, 2024

View reviewed changes

packages/@o3r/workspace/schematics/library/templates/ng/tsconfig.spec.json.template Show resolved Hide resolved

cpaulve-1A force-pushed the hotfix/2481 branch from 1de0da1 to d7b4c2a Compare December 13, 2024 16:18

fpaul-1A previously approved these changes Dec 13, 2024

View reviewed changes

cpaulve-1A dismissed fpaul-1A’s stale review via 392858a December 16, 2024 12:50

cpaulve-1A force-pushed the hotfix/2481 branch 2 times, most recently from 392858a to e700452 Compare December 17, 2024 11:42

kpanot reviewed Dec 17, 2024

View reviewed changes

packages/@o3r/workspace/schematics/library/index.ts Outdated Show resolved Hide resolved

cpaulve-1A force-pushed the hotfix/2481 branch from e700452 to d78b04b Compare December 17, 2024 16:43

github-actions bot added the project:@o3r/test-helpers label Dec 17, 2024

cpaulve-1A force-pushed the hotfix/2481 branch from d78b04b to 84d3dfd Compare December 18, 2024 09:09

cpaulve-1A commented Dec 18, 2024

View reviewed changes

packages/@o3r/test-helpers/src/utilities/package-manager.ts Outdated Show resolved Hide resolved

fpaul-1A reviewed Dec 18, 2024

View reviewed changes

packages/@o3r/workspace/schematics/library/rules/rules.ng.ts Outdated Show resolved Hide resolved

cpaulve-1A commented Dec 18, 2024

View reviewed changes

packages/@o3r/workspace/schematics/ng-add/helpers/npm-workspace.ts Outdated Show resolved Hide resolved

kpanot reviewed Dec 19, 2024

View reviewed changes

packages/@o3r/test-helpers/src/utilities/package-manager.ts Outdated Show resolved Hide resolved

packages/@o3r/workspace/schematics/library/index.spec.ts Outdated Show resolved Hide resolved

kpanot reviewed Dec 19, 2024

View reviewed changes

packages/@o3r/workspace/schematics/library/rules/rules.nx.ts Outdated Show resolved Hide resolved

cpaulve-1A force-pushed the hotfix/2481 branch 2 times, most recently from 90d7ac8 to 3341ac0 Compare January 6, 2025 14:55

vscaiceanu-1a previously approved these changes Jan 6, 2025

View reviewed changes

kpanot reviewed Jan 7, 2025

View reviewed changes

packages/@o3r/workspace/schematics/library/rules/shared.ts Outdated Show resolved Hide resolved

fpaul-1A previously approved these changes Jan 7, 2025

View reviewed changes

cpaulve-1A dismissed stale reviews from fpaul-1A and vscaiceanu-1a via f02ac1a January 7, 2025 17:09

cpaulve-1A force-pushed the hotfix/2481 branch from 3341ac0 to f02ac1a Compare January 7, 2025 17:09

kpanot reviewed Jan 8, 2025

View reviewed changes

packages/@o3r/workspace/schematics/library/templates/ng/tsconfig.spec.json.template Outdated Show resolved Hide resolved

cpaulve-1A force-pushed the hotfix/2481 branch 4 times, most recently from a6bcd4b to cb6f5bd Compare January 20, 2025 18:18

vscaiceanu-1a previously approved these changes Jan 21, 2025

View reviewed changes

cpaulve-1A dismissed vscaiceanu-1a’s stale review via 8d98aed January 21, 2025 17:24

cpaulve-1A force-pushed the hotfix/2481 branch from cb6f5bd to 8d98aed Compare January 21, 2025 17:24

cpaulve-1A changed the title ~~[draft] fix: the tsconfig spec generated for library contains several issues~~ fix: the tsconfig spec generated for library contains several issues Jan 21, 2025

cpaulve-1A marked this pull request as ready for review January 21, 2025 17:24

vscaiceanu-1a reviewed Jan 22, 2025

View reviewed changes

cpaulve-1A force-pushed the hotfix/2481 branch from 8d98aed to aba4841 Compare January 22, 2025 13:48

github-actions bot added the project:@o3r/eslint-config label Jan 22, 2025

kpanot reviewed Jan 22, 2025

View reviewed changes

packages/@o3r/components/schematics/index.it.spec.ts Outdated Show resolved Hide resolved

kpanot reviewed Jan 22, 2025

View reviewed changes

packages/@o3r/workspace/package.json Outdated Show resolved Hide resolved

matthieu-crouzet reviewed Jan 23, 2025

View reviewed changes

cpaulve-1A force-pushed the hotfix/2481 branch 2 times, most recently from 4544dbe to 41dbe91 Compare January 23, 2025 17:10

github-actions bot added project:audit-gh-action project:cascading-gh-action project:get-npm-tag-gh-action project:new-version-gh-action labels Jan 23, 2025

cpaulve-1A force-pushed the hotfix/2481 branch from 41dbe91 to 078c05b Compare January 24, 2025 09:05

fix: the tsconfig spec generated for library contains several issues

eca073c

Only use composite for library generated for workspace set up with jest. Ensure path do not target any invalid files.

cpaulve-1A force-pushed the hotfix/2481 branch from 078c05b to eca073c Compare January 24, 2025 10:02

fpaul-1A reviewed Jan 24, 2025

View reviewed changes

packages/@o3r/workspace/schematics/library/index.spec.ts Show resolved Hide resolved

fpaul-1A previously approved these changes Jan 24, 2025

View reviewed changes

cpaulve-1A dismissed fpaul-1A’s stale review via 8512aec January 24, 2025 11:10

cpaulve-1A force-pushed the hotfix/2481 branch from 8512aec to eca073c Compare January 24, 2025 11:13

fpaul-1A approved these changes Jan 24, 2025

View reviewed changes

cpaulve-1A enabled auto-merge January 24, 2025 14:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: the tsconfig spec generated for library contains several issues #2584

fix: the tsconfig spec generated for library contains several issues #2584

cpaulve-1A commented Dec 12, 2024 •

edited

Loading

nx-cloud bot commented Dec 12, 2024 •

edited

Loading

codecov bot commented Dec 12, 2024 •

edited

Loading

vscaiceanu-1a left a comment

matthieu-crouzet Jan 23, 2025

cpaulve-1A Jan 24, 2025

fix: the tsconfig spec generated for library contains several issues #2584

Are you sure you want to change the base?

fix: the tsconfig spec generated for library contains several issues #2584

Conversation

cpaulve-1A commented Dec 12, 2024 • edited Loading

Proposed change

Related issues

nx-cloud bot commented Dec 12, 2024 • edited Loading

codecov bot commented Dec 12, 2024 • edited Loading

Codecov Report

vscaiceanu-1a left a comment

Choose a reason for hiding this comment

matthieu-crouzet Jan 23, 2025

Choose a reason for hiding this comment

cpaulve-1A Jan 24, 2025

Choose a reason for hiding this comment

cpaulve-1A commented Dec 12, 2024 •

edited

Loading

nx-cloud bot commented Dec 12, 2024 •

edited

Loading

codecov bot commented Dec 12, 2024 •

edited

Loading