fix: do not call equal with an uninitialized value #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divdavem
force-pushed
the
dontCallEqualWithUninitializedValue
branch
from
41c2cdf to
9ac0756
Compare
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 98.58% 98.62% +0.03%
==========================================
Files 1 1
Lines 354 364 +10
Branches 63 64 +1
==========================================
+ Hits 349 359 +10
Partials 5 5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
divdavem
force-pushed
the
dontCallEqualWithUninitializedValue
branch
from
9ac0756 to
663f75a
Compare
divdavem
force-pushed
the
dontCallEqualWithUninitializedValue
branch
from
663f75a to
fa4b4d2
Compare
|
@fbasso Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.