Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: asWritable #114

Merged
merged 1 commit into from
Dec 8, 2023
Merged

feat: asWritable #114

merged 1 commit into from
Dec 8, 2023

Conversation

divdavem
Copy link
Member

@divdavem divdavem commented Dec 7, 2023

No description provided.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a3a998) 98.62% compared to head (1793d84) 98.64%.

❗ Current head 1793d84 differs from pull request most recent head 15e3ea2. Consider uploading reports for the commit 15e3ea2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   98.62%   98.64%   +0.02%     
==========================================
  Files           1        1              
  Lines         364      370       +6     
  Branches       64       67       +3     
==========================================
+ Hits          359      365       +6     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fbasso fbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @divdavem !

@divdavem
Copy link
Member Author

divdavem commented Dec 8, 2023

@fbasso Thank you for your review!

@divdavem divdavem merged commit 2776f34 into AmadeusITGroup:master Dec 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants