Merge pull request #26 from tribal-tec/master

Visibility not needed for static build

CMakeLists.txt

@@ -77,13 +77,13 @@ set(THREADS_PREFER_PTHREAD_FLAG ON)
 find_package(Threads REQUIRED)
 target_link_libraries(Async++ PUBLIC Threads::Threads)
 
-# Minimize the set of symbols exported by libraries
-set_target_properties(Async++ PROPERTIES CXX_VISIBILITY_PRESET hidden VISIBILITY_INLINES_HIDDEN ON)
-
 # Set up preprocessor definitions
 target_include_directories(Async++ PRIVATE ${PROJECT_SOURCE_DIR}/include)
 set_target_properties(Async++ PROPERTIES DEFINE_SYMBOL LIBASYNC_BUILD)
-if (NOT BUILD_SHARED_LIBS)
+if (BUILD_SHARED_LIBS)
+	# Minimize the set of symbols exported by libraries
+	set_target_properties(Async++ PROPERTIES CXX_VISIBILITY_PRESET hidden VISIBILITY_INLINES_HIDDEN ON)
+else()
 	target_compile_definitions(Async++ PUBLIC LIBASYNC_STATIC)
 endif()
 

include/async++.h

@@ -114,9 +114,11 @@
 #endif
 
 // Force symbol visibility to hidden unless explicity exported
+#ifndef LIBASYNC_STATIC
 #if defined(__GNUC__) && !defined(_WIN32)
 # pragma GCC visibility push(hidden)
 #endif
+#endif
 
 // Some forward declarations
 namespace async {
@@ -147,8 +149,10 @@ class event_task;
 #include "async++/parallel_for.h"
 #include "async++/parallel_reduce.h"
 
+#ifndef LIBASYNC_STATIC
 #if defined(__GNUC__) && !defined(_WIN32)
 # pragma GCC visibility pop
 #endif
+#endif
 
 #endif

src/internal.h

@@ -82,9 +82,11 @@
 #endif
 
 // Force symbol visibility to hidden unless explicity exported
+#ifndef LIBASYNC_STATIC
 #if defined(__GNUC__) && !defined(_WIN32)
 # pragma GCC visibility push(hidden)
 #endif
+#endif
 
 // Include other internal headers
 #include "singleton.h"

src/scheduler.cpp

@@ -239,6 +239,8 @@ wait_handler set_thread_wait_handler(wait_handler handler) LIBASYNC_NOEXCEPT
 
 } // namespace async
 
+#ifndef LIBASYNC_STATIC
 #if defined(__GNUC__) && !defined(_WIN32)
 # pragma GCC visibility pop
 #endif
+#endif

src/threadpool_scheduler.cpp

@@ -434,6 +434,8 @@ void threadpool_scheduler::schedule(task_run_handle t)
 
 } // namespace async
 
+#ifndef LIBASYNC_STATIC
 #if defined(__GNUC__) && !defined(_WIN32)
 # pragma GCC visibility pop
 #endif
+#endif