Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposed the as_ptr api, better inlining #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Exposed the as_ptr api, better inlining #34

wants to merge 2 commits into from
+48 −47

Conversation

adamnemecek
Copy link

Exposed the as_ptr API to match atomic. It's called as_ptr in line with this.

@Amanieu
Copy link
Owner

Amanieu commented Mar 5, 2023

#[inline(always)] is actively harmful in debug builds since it forces inlining when it is of no benefit. Just plain #[inline] is sufficient.

Amanieu
Amanieu reviewed Mar 5, 2023
View reviewed changes
src/lib.rs
fn inner_ptr(&self) -> *mut T {
/// Returns a mutable pointer to the underlying type.
///

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the empty lines.

@ds-cbo ds-cbo mentioned this pull request May 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amanieu Amanieu Amanieu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamnemecek @Amanieu